Skip to contentSkip to conversation

net: ipv6: Make address flushing on ifdown optional - v3

PATCH In review David Ahern 2 participants 4 messages Feb 12, 2015 – Feb 14, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ipv6: Make address flushing on ifdown optional - v3

Currently, all ipv6 addresses are flushed when the interface is configured down, even static address:

[root@f20 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000

    link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
    inet6 2000:11:1:1::1/64 scope global tentative
       valid_lft forever preferred_lft forever

[root@f20 ~]# ip link set dev eth1 up
[root@f20 ~]# ip link set dev eth1 down
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

    link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff

Add a new sysctl to make this behavior optional. The new setting defaults to flush all addresses to maintain backwards compatibility. When the setting is reset static addresses are not flushed:

[root@f20 ~]# echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down [root@f20 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

    link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
    inet6 2000:11:1:1::1/64 scope global tentative
       valid_lft forever preferred_lft forever

[root@f20 ~]# ip link set dev eth1 up
[root@f20 ~]# ip link set dev eth1 down
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

    link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
    inet6 2000:11:1:1::1/64 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::4:11ff:fe22:3301/64 scope link
       valid_lft forever preferred_lft forever

v3:
- fix local variable ordering and comment style per Dave's comment
- consistency in DEVCONF naming per Brian Haley's comment
- added entry to Documentation/networking/ip-sysctl.txt

v2:
- only keep static addresses as suggested by Hannes
- added new managed flag to track configured addresses
- on ifdown do not remove from configured address from inet6_addr_lst
- on ifdown reset the TENTATIVE flag and set state to DAD so that DAD is redone when link is brought up again

---
 Documentation/networking/ip-sysctl.txt |  6 ++++
 include/linux/ipv6.h                   |  1 +
 include/net/if_inet6.h                 |  1 +
 include/uapi/linux/ipv6.h              |  1 +
 net/ipv6/addrconf.c                    | 54 +++++++++++++++++++++++++++-------
 5 files changed, 53 insertions(+), 10 deletions(-)
Documentation/networking/ip-sysctl.txt +6 -0
index 1b8c964b0d17..a9e06c6ccfa4 100644
@@ -1341,6 +1341,12 @@ dad_transmits - INTEGER
 	The amount of Duplicate Address Detection probes to send.
 	Default: 1
 
+flush_addr_on_down - BOOLEAN
+	Flush all IPv6 addresses on an interface down event. If disabled
+	static addresses are not flushed.
+
+	Default: enabled
+
 forwarding - INTEGER
 	Configure interface-specific Host/Router behaviour.
 
include/linux/ipv6.h +1 -0
index 4d5169f5d7d1..92973b587be0 100644
@@ -53,6 +53,7 @@ struct ipv6_devconf {
 	__s32           ndisc_notify;
 	__s32		suppress_frag_ndisc;
 	__s32		accept_ra_mtu;
+	__s32		flush_addr_on_down;
 	void		*sysctl;
 };
 
include/net/if_inet6.h +1 -0
index 98e5f9578f86..3b6323111f77 100644
@@ -72,6 +72,7 @@ struct inet6_ifaddr {
 	int			regen_count;
 
 	bool			tokenized;
+	bool			managed;
 
 	struct rcu_head		rcu;
 	struct in6_addr		peer_addr;
include/uapi/linux/ipv6.h +1 -0
index 437a6a4b125a..9c31b90db187 100644
@@ -170,6 +170,7 @@ enum {
 	DEVCONF_ACCEPT_RA_FROM_LOCAL,
 	DEVCONF_USE_OPTIMISTIC,
 	DEVCONF_ACCEPT_RA_MTU,
+	DEVCONF_FLUSH_ADDR_ON_DOWN,
 	DEVCONF_MAX
 };
 
net/ipv6/addrconf.c +44 -10

123 lines not on this page · raw message

Signature · 1 line
1.9.3 (Apple Git-50)
#1 lore raw
Quoted 3 lines · David Ahern

Currently, all ipv6 addresses are flushed when the interface is configured down, even static address:

[snip]

Quoted 12 lines

[root@f20 ~]# echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down [root@f20 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global tentative
        valid_lft forever preferred_lft forever

[root@f20 ~]# ip link set dev eth1 up
[root@f20 ~]# ip link set dev eth1 down
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

Quoted 5 lines
     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global
        valid_lft forever preferred_lft forever
     inet6 fe80::4:11ff:fe22:3301/64 scope link
        valid_lft forever preferred_lft forever

Can you show an output of 'ip -6 route list table local' and 'ip -6 route' ?

#2 lore raw
Quoted 25 lines · Nicolas Dichtel
Quoted 4 lines · David Ahern

Currently, all ipv6 addresses are flushed when the interface is configured
down, even static address:

[snip]

Quoted 14 lines

[root@f20 ~]# echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down [root@f20 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64 [root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global tentative
        valid_lft forever preferred_lft forever

[root@f20 ~]# ip link set dev eth1 up
[root@f20 ~]# ip link set dev eth1 down
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

Quoted 5 lines
     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global
        valid_lft forever preferred_lft forever
     inet6 fe80::4:11ff:fe22:3301/64 scope link
        valid_lft forever preferred_lft forever
Quoted 2 lines

Can you show an output of 'ip -6 route list table local' and 'ip -6 route' ?

hmmmm.... interesting. once again ipv6 behavior is radically different from ipv4.

This is *after* a configure, up, down cycle:

[root@f21 ~]# ip -6 route list table local
local ::1 dev lo proto none metric 0
local 2000:11:1:1::1 dev lo proto none metric 0 local fe80::11:22ff:fe33:4402 dev lo proto none metric 0 ff00::/8 dev eth0 metric 256

[root@f21 ~]# ip -6 route ls
unreachable ::/96 dev lo metric 1024 error -101 unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101 unreachable 2002:a00::/24 dev lo metric 1024 error -101

unreachable 2002:7f00::/24 dev lo  metric 1024  error -101
unreachable 2002:a9fe::/32 dev lo  metric 1024  error -101
unreachable 2002:ac10::/28 dev lo  metric 1024  error -101
unreachable 2002:c0a8::/32 dev lo  metric 1024  error -101
unreachable 2002:e000::/19 dev lo  metric 1024  error -101
unreachable 3ffe:ffff::/32 dev lo  metric 1024  error -101

fe80::/64 dev eth0 proto kernel metric 256

(the ipv6 addresses on lo show up on stock 3.18.3-201.fc21.x86_64; no idea why)

But on a subsequent ifconfig up the route is not inserted:

[root@f21 ~]# ifconfig eth1 up

[root@f21 ~]# ip -6 route ls
unreachable ::/96 dev lo metric 1024 error -101 unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101 unreachable 2002:a00::/24 dev lo metric 1024 error -101

unreachable 2002:7f00::/24 dev lo  metric 1024  error -101
unreachable 2002:a9fe::/32 dev lo  metric 1024  error -101
unreachable 2002:ac10::/28 dev lo  metric 1024  error -101
unreachable 2002:c0a8::/32 dev lo  metric 1024  error -101
unreachable 2002:e000::/19 dev lo  metric 1024  error -101
unreachable 3ffe:ffff::/32 dev lo  metric 1024  error -101
fe80::/64 dev eth0  proto kernel  metric 256
fe80::/64 dev eth1  proto kernel  metric 256

So I need to look into why.

This is what happens on that stock kernel:

[root@f21 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64 [root@f21 ~]# ifconfig eth1
eth1: flags=4098<BROADCAST,MULTICAST> mtu 1500
inet6 2000:11:1:1::1 prefixlen 64 scopeid 0x0<global> ether 02:01:02:03:04:02 txqueuelen 1000 (Ethernet) RX packets 0 bytes 0 (0.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 0 bytes 0 (0.0 B)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0

Interface in down state and address configured.

[root@f21 ~]# ip -6 route list table local
local ::1 dev lo proto none metric 0
local fe80::11:22ff:fe33:4402 dev lo proto none metric 0 ff00::/8 dev eth0 metric 256
ff00::/8 dev eth1 metric 256

[root@f21 ~]# ip -6 route ls
unreachable ::/96 dev lo metric 1024 error -101 unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101 2000:11:1:1::/64 dev eth1 proto kernel metric 256 unreachable 2002:a00::/24 dev lo metric 1024 error -101

unreachable 2002:7f00::/24 dev lo  metric 1024  error -101
unreachable 2002:a9fe::/32 dev lo  metric 1024  error -101
unreachable 2002:ac10::/28 dev lo  metric 1024  error -101
unreachable 2002:c0a8::/32 dev lo  metric 1024  error -101
unreachable 2002:e000::/19 dev lo  metric 1024  error -101
unreachable 3ffe:ffff::/32 dev lo  metric 1024  error -101

fe80::/64 dev eth0 proto kernel metric 256

And there is an entry in the FIB which just seems wrong. It's cleaned out on an up/down cycle.

David

#3 lore raw
Quoted 31 lines · David Ahern
Quoted 25 lines · Nicolas Dichtel
Quoted 4 lines · David Ahern

Currently, all ipv6 addresses are flushed when the interface is configured
down, even static address:

[snip]

Quoted 14 lines

[root@f20 ~]# echo 0 > /proc/sys/net/ipv6/conf/eth1/flush_addr_on_down [root@f20 ~]# ip -6 addr add dev eth1 2000:11:1:1::1/64 [root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global tentative
        valid_lft forever preferred_lft forever

[root@f20 ~]# ip link set dev eth1 up
[root@f20 ~]# ip link set dev eth1 down
[root@f20 ~]# ip addr show dev eth1
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000

Quoted 5 lines
     link/ether 02:04:11:22:33:01 brd ff:ff:ff:ff:ff:ff
     inet6 2000:11:1:1::1/64 scope global
        valid_lft forever preferred_lft forever
     inet6 fe80::4:11ff:fe22:3301/64 scope link
        valid_lft forever preferred_lft forever
Quoted 2 lines

Can you show an output of 'ip -6 route list table local' and 'ip -6 route' ?

hmmmm.... interesting. once again ipv6 behavior is radically different from ipv4.

Quoted 7 lines

This is *after* a configure, up, down cycle:

[root@f21 ~]# ip -6 route list table local
local ::1 dev lo proto none metric 0
local 2000:11:1:1::1 dev lo proto none metric 0 local fe80::11:22ff:fe33:4402 dev lo proto none metric 0 ff00::/8 dev eth0 metric 256

We also need to check netlink notifications. When you set an interface down, the kernel doesn't send rtnl notifications for IPv6 routes. Daemons have to take care of the ifdow notification.
If your patch is going to keep some routes after an ifdown, we need to have a way in userland to know this.
Advertising the new sysctl (flush_addr_on_down) entry via netconf may be a solution (Stephen already talks about this feature).

Quoted 32 lines

[root@f21 ~]# ip -6 route ls
unreachable ::/96 dev lo metric 1024 error -101 unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101 unreachable 2002:a00::/24 dev lo metric 1024 error -101

unreachable 2002:7f00::/24 dev lo  metric 1024  error -101
unreachable 2002:a9fe::/32 dev lo  metric 1024  error -101
unreachable 2002:ac10::/28 dev lo  metric 1024  error -101
unreachable 2002:c0a8::/32 dev lo  metric 1024  error -101
unreachable 2002:e000::/19 dev lo  metric 1024  error -101
unreachable 3ffe:ffff::/32 dev lo  metric 1024  error -101

fe80::/64 dev eth0 proto kernel metric 256

(the ipv6 addresses on lo show up on stock 3.18.3-201.fc21.x86_64; no idea why)

But on a subsequent ifconfig up the route is not inserted:

[root@f21 ~]# ifconfig eth1 up

[root@f21 ~]# ip -6 route ls
unreachable ::/96 dev lo metric 1024 error -101 unreachable ::ffff:0.0.0.0/96 dev lo metric 1024 error -101 unreachable 2002:a00::/24 dev lo metric 1024 error -101

unreachable 2002:7f00::/24 dev lo  metric 1024  error -101
unreachable 2002:a9fe::/32 dev lo  metric 1024  error -101
unreachable 2002:ac10::/28 dev lo  metric 1024  error -101
unreachable 2002:c0a8::/32 dev lo  metric 1024  error -101
unreachable 2002:e000::/19 dev lo  metric 1024  error -101
unreachable 3ffe:ffff::/32 dev lo  metric 1024  error -101
fe80::/64 dev eth0  proto kernel  metric 256
fe80::/64 dev eth1  proto kernel  metric 256
Quoted 1 line

So I need to look into why.

Yes. The patch will probably have to play with this connected route.

Regards,
Nicolas