Staging: iio: meter: ade7854-i2c: code style improvements
Subsystems (4)
PATCH 1/1 Staging: iio: meter: ade7854-i2c: code style improvements
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
Signed-off-by Tolga Ceylan <[email protected]>
--- drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++---------------- 1 file changed, 20 insertions(+), 19 deletions(-)
drivers/staging/iio/meter/ade7854-i2c.c +20 -19
@@ -16,8 +16,8 @@#include "ade7854.h" static int ade7854_i2c_write_reg_8 (struct device *dev, -u16 reg_address, -u8 value) +u16 reg_address, +u8 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev, }static int ade7854_i2c_write_reg_16 (struct device *dev, -u16 reg_address, -u16 value) +u16 reg_address, +u16 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev, }static int ade7854_i2c_write_reg_24 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev, }static int ade7854_i2c_write_reg_32 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev, }static int ade7854_i2c_read_reg_8 (struct device *dev, -u16 reg_address, -u8 *val) +u16 reg_address, +u8 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -124,8 +124,8 @@ out: }static int ade7854_i2c_read_reg_16 (struct device *dev, -u16 reg_address, -u16 *val) +u16 reg_address, +u16 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -150,8 +150,8 @@ out: }static int ade7854_i2c_read_reg_24 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -176,8 +176,8 @@ out: }static int ade7854_i2c_read_reg_32 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -195,21 +195,22 @@ static int ade7854_i2c_read_reg_32(struct device *dev,if (ret) goto out; - *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) | (st->rx[2 ] <<8 ) | st->rx[3 ]; + *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) + | (st->rx[2 ] <<8 ) | st->rx[3 ]; out:mutex_unlock (&st->buf_lock);return ret; }static int ade7854_i2c_probe (struct i2c_client *client, -const struct i2c_device_id *id) +const struct i2c_device_id *id) {int ret;struct ade7854_state *st;struct iio_dev *indio_dev; indio_dev =devm_iio_device_alloc (&client->dev,sizeof (*st)); -if (indio_dev ==NULL ) +if (!indio_dev)return -ENOMEM ; st =iio_priv (indio_dev);i2c_set_clientdata (client, indio_dev);
Signature · 1 line
2.3.0
Quoted 4 lines · Tolga Ceylan
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
you are doing three different types of changes here. one patch should have only one type of change.
regards
sudip
Quoted 7 lines
Signed-off-by Tolga Ceylan <[email protected]>--- drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++---------------- 1 file changed, 20 insertions(+), 19 deletions(-)
Quoted 5 lines · Sudip Mukherjee
you are doing three different types of changes here. one patch should have only one type of change.
regards
sudip
Thank you, I'll split this up and resubmit.
Regards,
Tolga