Skip to contentSkip to conversation

dgnc: Use ccflags -y instead of EXTRA_CFLAGS

PATCH In review Cass May 2 participants 2 messages Feb 13, 2015 Staging

lore
Share & tools
lore

Cass May

author
#0 lore raw

PATCH v2 1/1 dgnc: Use ccflags -y instead of EXTRA_CFLAGS

Correction to syntax error in previous patch version. Apologies.

---
 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/Makefile +1 -1
index b69f7b6..a278900 100644
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
 
 obj-$(CONFIG_DGNC) += dgnc.o
 
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Cass May

Correction to syntax error in previous patch version. Apologies.

Put that stuff under the --- cut off line and not in the permanent kernel git log.

Changelog is missing. checkpatch.pl by itself is not sufficient justification. Why did the authors of checkpatch think this way is better?

drivers/staging/dgnc/Makefile line 1

Quoted 12 lines
---
 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/Makefile +1 -1
index b69f7b6..a278900 100644
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"

This isn't the right fix. Is this stuff even needed? Hopefully, not but please check and resend a different fix.

regards,
dan carpenter