Staging: iio: meter: ade7854-i2c: code style improvements
Subsystems (4)
PATCH 1/3 Staging: iio: meter: ade7854-i2c: code style improvements
Code reformatting based on checkpatch.pl with --strict:
Alignment should match open paranthesis cases corrected
--- drivers/staging/iio/meter/ade7854-i2c.c | 34 ++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
drivers/staging/iio/meter/ade7854-i2c.c +17 -17
@@ -16,8 +16,8 @@#include "ade7854.h" static int ade7854_i2c_write_reg_8 (struct device *dev, -u16 reg_address, -u8 value) +u16 reg_address, +u8 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev, }static int ade7854_i2c_write_reg_16 (struct device *dev, -u16 reg_address, -u16 value) +u16 reg_address, +u16 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev, }static int ade7854_i2c_write_reg_24 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev, }static int ade7854_i2c_write_reg_32 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);
@@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev, }static int ade7854_i2c_read_reg_8 (struct device *dev, -u16 reg_address, -u8 *val) +u16 reg_address, +u8 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -124,8 +124,8 @@ out: }static int ade7854_i2c_read_reg_16 (struct device *dev, -u16 reg_address, -u16 *val) +u16 reg_address, +u16 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -150,8 +150,8 @@ out: }static int ade7854_i2c_read_reg_24 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -176,8 +176,8 @@ out: }static int ade7854_i2c_read_reg_32 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);
@@ -202,7 +202,7 @@ out: }static int ade7854_i2c_probe (struct i2c_client *client, -const struct i2c_device_id *id) +const struct i2c_device_id *id) {int ret;struct ade7854_state *st;
Signature · 1 line
2.3.0
PATCH 2/3 Staging: iio: meter: ade7854-i2c: code style improvements
Code reformatting based on checkpatch.pl with --strict:
Lines over 80 characters were fixed
--- drivers/staging/iio/meter/ade7854-i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/iio/meter/ade7854-i2c.c +2 -1
@@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,if (ret) goto out; - *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) | (st->rx[2 ] <<8 ) | st->rx[3 ]; + *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) | + (st->rx[2 ] <<8 ) | st->rx[3 ]; out:mutex_unlock (&st->buf_lock);return ret;
Signature · 1 line
2.3.0
Jonathan Cameron
maintainerQuoted 4 lines · Tolga Ceylan
Code reformatting based on checkpatch.pl with --strict:
Lines over 80 characters were fixedSigned-off-by Tolga Ceylan <[email protected]>
You sent me a patch for this a week before this one which was applied. So already done :)
Quoted 19 lines
--- drivers/staging/iio/meter/ade7854-i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/iio/meter/ade7854-i2c.c +2
-1@@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,if (ret) goto out; - *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) | (st->rx[2 ] <<8 ) | st->rx[3 ]; + *val = (st->rx[0 ] <<24 ) | (st->rx[1 ] <<16 ) | + (st->rx[2 ] <<8 ) | st->rx[3 ]; out:mutex_unlock (&st->buf_lock);return ret;
PATCH 3/3 Staging: iio: meter: ade7854-i2c: code style improvements
In reply to Tolga CeylanCode reformatting based on checkpatch.pl with --strict:
Comparison to NULL rewritten as !indio_dev
--- drivers/staging/iio/meter/ade7854-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/meter/ade7854-i2c.c +1 -1
@@ -210,7 +210,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,struct iio_dev *indio_dev; indio_dev =devm_iio_device_alloc (&client->dev,sizeof (*st)); -if (indio_dev ==NULL ) +if (!indio_dev)return -ENOMEM ; st =iio_priv (indio_dev);i2c_set_clientdata (client, indio_dev);
Signature · 1 line
2.3.0
Quoted 4 lines · Tolga Ceylan
Code reformatting based on checkpatch.pl with --strict:
Comparison to NULL rewritten as !indio_devSigned-off-by Tolga Ceylan <[email protected]>
Whilst I find it hard to care on this particular fix.. what the heck.
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
Quoted 18 lines
--- drivers/staging/iio/meter/ade7854-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/iio/meter/ade7854-i2c.c +1
-1@@ -210,7 +210,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,struct iio_dev *indio_dev; indio_dev =devm_iio_device_alloc (&client->dev,sizeof (*st)); -if (indio_dev ==NULL ) +if (!indio_dev)return -ENOMEM ; st =iio_priv (indio_dev);i2c_set_clientdata (client, indio_dev);
Quoted 4 lines · Tolga Ceylan
Code reformatting based on checkpatch.pl with --strict:
Alignment should match open paranthesis cases correctedSigned-off-by Tolga Ceylan <[email protected]>
Applied to the togreg branch of iio.git - will initially be pushed out as testing for the autobuilders to play.
Thanks
Jonathan
Quoted 106 lines
--- drivers/staging/iio/meter/ade7854-i2c.c | 34 ++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)drivers/staging/iio/meter/ade7854-i2c.c +17
-17@@ -16,8 +16,8 @@#include "ade7854.h" static int ade7854_i2c_write_reg_8 (struct device *dev, -u16 reg_address, -u8 value) +u16 reg_address, +u8 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);@@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev, }static int ade7854_i2c_write_reg_16 (struct device *dev, -u16 reg_address, -u16 value) +u16 reg_address, +u16 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);@@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev, }static int ade7854_i2c_write_reg_24 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);@@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev, }static int ade7854_i2c_write_reg_32 (struct device *dev, -u16 reg_address, -u32 value) +u16 reg_address, +u32 value) {int ret;struct iio_dev *indio_dev =dev_to_iio_dev (dev);@@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev, }static int ade7854_i2c_read_reg_8 (struct device *dev, -u16 reg_address, -u8 *val) +u16 reg_address, +u8 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);@@ -124,8 +124,8 @@ out: }static int ade7854_i2c_read_reg_16 (struct device *dev, -u16 reg_address, -u16 *val) +u16 reg_address, +u16 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);@@ -150,8 +150,8 @@ out: }static int ade7854_i2c_read_reg_24 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);@@ -176,8 +176,8 @@ out: }static int ade7854_i2c_read_reg_32 (struct device *dev, -u16 reg_address, -u32 *val) +u16 reg_address, +u32 *val) {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct ade7854_state *st =iio_priv (indio_dev);@@ -202,7 +202,7 @@ out: }static int ade7854_i2c_probe (struct i2c_client *client, -const struct i2c_device_id *id) +const struct i2c_device_id *id) {int ret;struct ade7854_state *st;