Revert "ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C"
PATCH 1/1 Revert "ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C"
Revert commit b893e80e3147 ("ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C") because it causes touchpad to not load on Dell XPS13.
Regression is a clear indication that not only some early prototype version of Lynxpoint I2C but also newer versions can be doing clock gating even documentation does not state it.
Therefore it is best to revert since this clock gating haven't caused known issues on those Lynxpoint version which don't do clock gating.
---
For v3.20.
--- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +1 -1
@@ -125,7 +125,7 @@ static struct lpss_device_desc lpt_dev_desc = { };static struct lpss_device_desc lpt_i2c_dev_desc = { - .flags =LPSS_CLK |LPSS_LTR , + .flags =LPSS_CLK |LPSS_CLK_GATE |LPSS_LTR , .prv_offset =0x800 , };
Signature · 1 line
2.1.4
Quoted 24 lines · Jarkko Nikula
Revert commit
b893e80e3147("ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C") because it causes touchpad to not load on Dell XPS13.Regression is a clear indication that not only some early prototype version of Lynxpoint I2C but also newer versions can be doing clock gating even documentation does not state it.
Therefore it is best to revert since this clock gating haven't caused known issues on those Lynxpoint version which don't do clock gating.
Reported-by Chris Rorvick <[email protected]>Signed-off-by Jarkko Nikula <[email protected]>---
For v3.20.--- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/acpi_lpss.c +0
-0
drivers/acpi/acpi_lpss.c static struct lpss_device_desc lpt_dev_desc = { · line 130
Quoted 7 lines
drivers/acpi/acpi_lpss.c +1
-1@@ -125,7 +125,7 @@ static struct lpss_device_desc lpt_dev_desc = { };static struct lpss_device_desc lpt_i2c_dev_desc = { - .flags =LPSS_CLK |LPSS_LTR , + .flags =LPSS_CLK |LPSS_CLK_GATE |LPSS_LTR , .prv_offset =0x800 , };
Rafael J. Wysocki
AppliedQuoted 8 lines · Jarkko Nikula
Revert commit
b893e80e3147("ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C") because it causes touchpad to not load on Dell XPS13.Regression is a clear indication that not only some early prototype version of Lynxpoint I2C but also newer versions can be doing clock gating even documentation does not state it.
Quoted 5 lines
Therefore it is best to revert since this clock gating haven't caused known issues on those Lynxpoint version which don't do clock gating.
Reported-by Chris Rorvick <[email protected]>Signed-off-by Jarkko Nikula <[email protected]>
Applied, thanks!
Quoted 20 lines
---
For v3.20.--- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/acpi_lpss.c +1
-1@@ -125,7 +125,7 @@ static struct lpss_device_desc lpt_dev_desc = { };static struct lpss_device_desc lpt_i2c_dev_desc = { - .flags =LPSS_CLK |LPSS_LTR , + .flags =LPSS_CLK |LPSS_CLK_GATE |LPSS_LTR , .prv_offset =0x800 , };
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.