insane.bbclass: Enhance file-rdeps QA check
PATCH 1/1 insane.bbclass: Enhance file-rdeps QA check
Adds symlink-to-sysroot check to the QA_WARN, Changes filerdepends from set() to dict(), hence methodsfor adding or deleting items had to change, keeps track of the key:value relationship, flags the issue along with the offending file accordingly.
--- meta/classes/insane.bbclass | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-)
meta/classes/insane.bbclass +11 -15
@@ -34,7 +34,7 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ split-strip packages-list pkgv-undefined var-undefined \ - version-going-backwards \ + version-going-backwards symlink-to-sysroot\ " ALL_QA = "${WARN_QA} ${ERROR_QA}"
@@ -604,7 +604,6 @@ def package_qa_check_symlink_to_sysroot(path, name, d, elf, messages): if target.startswith(tmpdir): trimmed = path.replace(os.path.join (d.getVar("PKGDEST", True), name), "") messages["symlink-to-sysroot"] = "Symlink %s in %s points to TMPDIR" % (trimmed, name) - def package_qa_check_license(workdir, d): """ Check for changes in the license files
@@ -803,13 +802,14 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d): if bb.data.inherits_class('nativesdk', d): ignored_file_rdeps |= set(['/bin/bash', '/usr/bin/perl']) # For Saving the FILERDEPENDS - filerdepends = set() + filerdepends = {} rdep_data = oe.packagedata.read_subpkgdata(pkg, d) for key in rdep_data: if key.startswith("FILERDEPENDS_"): for subkey in rdep_data[key].split(): - filerdepends.add(subkey) - filerdepends -= ignored_file_rdeps + if subkey not in ignored_file_rdeps: + # We already know it starts with FILERDEPENDS_ + filerdepends[subkey] = key[13:] if filerdepends: next = rdepends
@@ -841,31 +841,27 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d): # case there is a RDEPENDS_pkg = "python" in the recipe. for py in [ d.getVar('MLPREFIX', True) + "python", "python" ]: if py in done: - filerdepends.discard("/usr/bin/python") + filerdepends.pop("/usr/bin/python",None) done.remove(py) for rdep in done: # For Saving the FILERPROVIDES, RPROVIDES and FILES_INFO - rdep_rprovides = set() rdep_data = oe.packagedata.read_subpkgdata(rdep, d) for key in rdep_data: if key.startswith("FILERPROVIDES_") or key.startswith("RPROVIDES_"): for subkey in rdep_data[key].split(): - rdep_rprovides.add(subkey) + filerdepends.pop(subkey,None) # Add the files list to the rprovides if key == "FILES_INFO": # Use eval() to make it as a dict for subkey in eval(rdep_data[key]): - rdep_rprovides.add(subkey) - filerdepends -= rdep_rprovides + filerdepends.pop(subkey,None) if not filerdepends: # Break if all the file rdepends are met break - else: - # Clear it for the next loop - rdep_rprovides.clear() if filerdepends: - error_msg = "%s requires %s, but no providers in its RDEPENDS" % \ - (pkg, ', '.join(str(e) for e in filerdepends)) + for key in filerdepends: + error_msg = "%s contained in package %s requires %s, but no providers found in its RDEPENDS" % \ + (filerdepends[key],pkg, key) sane = package_qa_handle_error("file-rdeps", error_msg, d) return sane
Signature · 1 line
1.9.1
Quoted 2 lines · Alejandro Hernandez
Adds symlink-to-sysroot check to the
QA_WARN, Changes filerdepends fromset()todict(), hence methodsfor adding or deleting items had
methods for
Quoted 13 lines
to change, keeps track of the key:value relationship, flags the issue along with the offending file accordingly.
Signed-off-by Alejandro Hernandez <[email protected]>--- meta/classes/insane.bbclass | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-)meta/classes/insane.bbclass +0
-0
meta/classes/insane.bbclass WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ · line 37
Quoted 5 lines
meta/classes/insane.bbclass +1
-1@@ -34,7 +34,7 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ split-strip packages-list pkgv-undefined var-undefined \ - version-going-backwards \ + version-going-backwards symlink-to-sysroot\
Is this a 'development change' which should be dropped or another change which should go in another commit?
Please take a look on the 'sed' warning when building with ptest. It is a 'false-positive' failure.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 8 lines · Otavio Salvador
meta/classes/insane.bbclass +1
-1@@ -34,7 +34,7 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ split-strip packages-list pkgv-undefined var-undefined \ - version-going-backwards \ + version-going-backwards symlink-to-sysroot\Is this a 'development change' which should be dropped or another change which should go in another commit?
Yes, development change, this should go in WARN_QA
Quoted 4 lines
Please take a look on the 'sed' warning when building with ptest. It is a 'false-positive' failure.
As discussed in the IRC this is related to a different bug, its a "build-deps" bug not "file-rdeps", I would gladly fix it, although I am not able to reproduce it so far, if anyone can and has some info, I'd appreciate it.
Quoted 4 lines · Alejandro Hernandez
Adds symlink-to-sysroot check to the
QA_WARN, Changes filerdepends fromset()todict(), hence methodsfor adding or deleting items had to change, keeps track of the key:value relationship, flags the issue along with the offending file accordingly.
I'm sure this is a good change but I'm struggling to understand it from the message above. Could you make sure to say:
a) What the change does
b) Why its important/useful
as well as how the change modifies the code (which you cover).
Cheers,
Richard