Skip to contentSkip to conversation

ath10k: Remove trace about getting temperature

PATCH In review Matthias Kaehlcke 3 participants 4 messages Feb 24, 2015 – Mar 12, 2015 1 message not in the archive Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Remove trace about getting temperature

When ath10k debugging is enabled this trace generates a log entry every time the chip temperature is read. On systems polling the temperature this clutters the log with entries which aren't particularly useful. Remove this trace.

---
 drivers/net/wireless/ath/ath10k/wmi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi.c +0 -1
index aeea1c7..1c86984 100644
@@ -4881,7 +4881,6 @@ ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar)
 	if (!skb)
 		return ERR_PTR(-ENOMEM);
 
-	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
 	return skb;
 }
 
Signature · 7 lines
2.2.0.rc0.207.ga3a616c


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 15 lines · Matthias Kaehlcke

When ath10k debugging is enabled this trace generates a log entry every time the chip temperature is read. On systems polling the temperature this clutters the log with entries which aren't particularly useful. Remove this trace.

---
 drivers/net/wireless/ath/ath10k/wmi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi.c +0 -0
index aeea1c7..1c86984 100644

drivers/net/wireless/ath/ath10k/wmi.c ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar) · line 4884

Quoted 5 lines
drivers/net/wireless/ath/ath10k/wmi.c +0 -1
@@ -4881,7 +4881,6 @@ ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar)
 	if (!skb)
 		return ERR_PTR(-ENOMEM);
 
-	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
 	return skb;

I'm worried that this is dangerous, as that means that not all WMI commands will be in debug and something might be missed because of that.

Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or adding a new log level?

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
Quoted 20 lines · Kalle Valo
Quoted 18 lines · Matthias Kaehlcke

When ath10k debugging is enabled this trace generates a log entry every time the chip temperature is read. On systems polling the temperature this clutters the log with entries which aren't particularly useful. Remove this trace.

---
 drivers/net/wireless/ath/ath10k/wmi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi.c +0 -0
index aeea1c7..1c86984 100644
@@ -4881,7 +4881,6 @@ ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar)
      if (!skb)
              return ERR_PTR(-ENOMEM);
 
Quoted 5 lines

drivers/net/wireless/ath/ath10k/wmi.c ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar) · line 4884

Quoted 2 lines
drivers/net/wireless/ath/ath10k/wmi.c +0 -1
-     ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
      return skb;

I'm worried that this is dangerous, as that means that not all WMI commands will be in debug and something might be missed because of that.

I see your concern

Quoted 2 lines

Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or adding a new log level?

Switching to dynamic debugging (dev_dbg, ...) could be an option. Debug messages would be disabled by default but can be enabled at runtime

Signature · 6 lines
Matthias Kaehlcke | Software Engineer | [email protected]

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

A message that is not in the archive (sent off-list or not yet received): CAKZ8rEOVf4q_i7at=h3PiwwGDNeuiEL467wFCOwADwd0BhtbCw@mail.gmail.com

#4 lore raw
Quoted 10 lines · Matthias Kaehlcke
Quoted 2 lines
-     ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
      return skb;

I'm worried that this is dangerous, as that means that not all WMI commands will be in debug and something might be missed because of that.

I see your concern

Quoted 6 lines

Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or adding a new log level?

Switching to dynamic debugging (dev_dbg, ...) could be an option. Debug messages would be disabled by default but can be enabled at runtime

I don't really like dynamic debugging framework as it's not really convenient with bigger drivers like ath10k. Is it possible to add support for dynamic debugging without sacrificing the current debug functionality, especially setting debug levels via debug_mask parameters?

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k