Staging: rtl8723au: Remove spaces at the start of a line
PATCH 1/1 Staging: rtl8723au: Remove spaces at the start of a line
WARNING: please, no spaces at the start of a line
That was found by running checkpatch.
--- drivers/staging/rtl8723au/hal/odm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8723au/hal/odm.c +6 -6
@@ -216,16 +216,16 @@ static void ODM_EdcaTurboInit23a(struct dm_odm_t *pDM_Odm);#define RxDefaultAnt2 0x569abool odm_StaDefAntSel (struct dm_odm_t *pDM_Odm, -u32 OFDM_Ant1_Cnt, -u32 OFDM_Ant2_Cnt, -u32 CCK_Ant1_Cnt, -u32 CCK_Ant2_Cnt, -u8 *pDefAnt +u32 OFDM_Ant1_Cnt, +u32 OFDM_Ant2_Cnt, +u32 CCK_Ant1_Cnt, +u32 CCK_Ant2_Cnt, +u8 *pDefAnt );void odm_SetRxIdleAnt (struct dm_odm_t *pDM_Odm,u8 Ant, -bool bDualPath +bool bDualPath );/* 3 Export Interface */
Signature · 1 line
1.8.3.2
Quoted 16 lines · Melike Yurtoglu
WARNING: please, no spaces at the start of a line
That was found by running checkpatch.Signed-off-by Melike Yurtoglu <[email protected]>--- drivers/staging/rtl8723au/hal/odm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/staging/rtl8723au/hal/odm.c +0
-0@@ -216,16 +216,16 @@ static void ODM_EdcaTurboInit23a(struct dm_odm_t *pDM_Odm);#define RxDefaultAnt2 0x569a bool odm_StaDefAntSel(struct dm_odm_t *pDM_Odm,
drivers/staging/rtl8723au/hal/odm.c static void ODM_EdcaTurboInit23a(struct dm_odm_t *pDM_Odm); · line 223
Quoted 10 lines
drivers/staging/rtl8723au/hal/odm.c +5
-5-u32 OFDM_Ant1_Cnt, - u32 OFDM_Ant2_Cnt, - u32 CCK_Ant1_Cnt, - u32 CCK_Ant2_Cnt, - u8 *pDefAnt +u32 OFDM_Ant1_Cnt, +u32 OFDM_Ant2_Cnt, +u32 CCK_Ant1_Cnt, +u32 CCK_Ant2_Cnt, +u8 *pDefAnt
This does not seem like a good solution. I think that the meaning of the message is that there should be tabs, not spaces.
drivers/staging/rtl8723au/hal/odm.c static void ODM_EdcaTurboInit23a(struct dm_odm_t *pDM_Odm); · line 228
Quoted 6 lines
drivers/staging/rtl8723au/hal/odm.c +1
-1);void odm_SetRxIdleAnt (struct dm_odm_t *pDM_Odm,u8 Ant, - bool bDualPath +bool bDualPath
Likewise, here all of the arguments should be lines up in some way. Perhaps check what is done elsewhere in the file. One would think that there would even be enough room on a single line here, but maybe not quite.
julia
Quoted 13 lines
drivers/staging/rtl8723au/hal/odm.c +0
-0);/* 3 Export Interface */ Signature · 8 lines
1.8.3.2 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424903168-10197-1-git-send-email-aysemelikeyurtoglu%40gmail.com. For more options, visit https://groups.google.com/d/optout.