lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")
PATCH 1/1 lib/igt_kms.c: igt_require -> igt_require_f("two displays required\n")
The bare "Test requirement: modes" message is too cryptic, I had to go and read the source code to understand the missing requirement.
Signed-off-by Marc Herbert <[email protected]>
---
If there is a different message that you would like to push yourself then please don't mind me - I think ANY message would do.
tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_flip.c +1 -1
@@ -1544,7 +1544,7 @@ static int run_pair(int duration, int flags)/* If we have fewer than 2 connected outputs then we won't have any * configuration at all. So skip in that case. */ -igt_require (modes); +igt_require_f (modes,"At least two displays required\n" ); duration = duration *1000 / modes; duration =max (duration,500 );
Signature · 6 lines
1.9.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Marc Herbert
The bare "Test requirement: modes" message is too cryptic, I had to go and read the source code to understand the missing requirement.
Signed-off-by Marc Herbert <[email protected]>
Nice one, applied.
Thanks, Daniel
Quoted 28 lines
---
If there is a different message that you would like to push yourself then please don't mind me - I think ANY message would do.
tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_flip.c +1
-1@@ -1544,7 +1544,7 @@ static int run_pair(int duration, int flags)/* If we have fewer than 2 connected outputs then we won't have any * configuration at all. So skip in that case. */ -igt_require (modes); +igt_require_f (modes,"At least two displays required\n" ); duration = duration *1000 / modes; duration =max (duration,500 );Signature · 6 lines
1.9.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx