Skip to contentSkip to conversation

ARM: DT: apq8064: specify memory in dts file

PATCH In review Rob Clark 2 participants 3 messages Mar 2, 2015 – Mar 19, 2015

Subsystems (2)
Device tree bindings Arm Qualcomm mailing list
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 ARM: DT: apq8064: specify memory in dts file

Seems required for kexec (where --atags support is mutually exclusive with --dtb).

Signed-off-by Rob Clark <[email protected]>
---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +9 -0
index b396c83..fa40409 100644
@@ -4,6 +4,15 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x08e00000
+				0x8a000000 0x03a00000
+				0x8ec00000 0x00400000
+				0x8f700000 0x00700000
+				0x90000000 0x70000000>;
+	};
+
 	soc {
 		pinctrl@800000 {
 			i2c1_pins: i2c1 {
Signature · 1 line
2.1.0
#1 lore raw
Quoted 15 lines · Rob Clark

Seems required for kexec (where --atags support is mutually exclusive with --dtb).

Signed-off-by Rob Clark <[email protected]>

---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++

1 file changed, 9 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index b396c83..fa40409 100644
@@ -4,6 +4,15 @@
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 15

Quoted 10 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +9 -0
 
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x08e00000
+				0x8a000000 0x03a00000
+				0x8ec00000 0x00400000
+				0x8f700000 0x00700000
+				0x90000000 0x70000000>;
+	};
+

Curious, where did you get these ranges from?

- k

Quoted 10 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
 	soc {
 		pinctrl@800000 {
 			i2c1_pins: i2c1 {
Signature · 6 lines
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#2 lore raw
Quoted 19 lines · Kumar Gala
Quoted 16 lines · Rob Clark

Seems required for kexec (where --atags support is mutually exclusive with --dtb).

Signed-off-by Rob Clark <[email protected]>

---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++

1 file changed, 9 insertions(+)
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -0
index b396c83..fa40409 100644
@@ -4,6 +4,15 @@
      model = "Qualcomm APQ8064/IFC6410";
      compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
Quoted 11 lines

arch/arm/boot/dts/qcom-apq8064-ifc6410.dts line 15

Quoted 9 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +9 -0
+     memory {
+             device_type = "memory";
+             reg = <0x80000000 0x08e00000
+                             0x8a000000 0x03a00000
+                             0x8ec00000 0x00400000
+                             0x8f700000 0x00700000
+                             0x90000000 0x70000000>;
+     };
+

Curious, where did you get these ranges from?

iirc, I was working backwards from the ranges that it gets atags when I boot directly from bootloader (rather than kexec)

I cannot guarantee them 100%, but board booted up ok, gnome-shell, etc worked.. I didn't see any obvious signs of memory corruption, so it seemed like it was working.

BR,
-R

Quoted 19 lines

- k

Quoted 10 lines
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +0 -1
      soc {
              pinctrl@800000 {
                      i2c1_pins: i2c1 {
--

2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project