Skip to contentSkip to conversation

phy: samsung-usb2: Remove NULL terminating entry from phys array

PATCH In review Axel Lin 2 participants 2 messages Mar 3, 2015 – Mar 4, 2015

Subsystems (2)
Arm Samsung Exynos Generic PHY framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 phy: samsung-usb2: Remove NULL terminating entry from phys array

Current code uses num_phys settings to tell the number of entries in phys. Thus remove the NULL terminating entry from phys array which is not necessary.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/phy/phy-exynos4210-usb2.c | 1 -
 drivers/phy/phy-exynos4x12-usb2.c | 1 -
 drivers/phy/phy-exynos5250-usb2.c | 1 -
 3 files changed, 3 deletions(-)
drivers/phy/phy-exynos4210-usb2.c +0 -1
index 236a52a..f30bbb0 100644
@@ -250,7 +250,6 @@ static const struct samsung_usb2_common_phy exynos4210_phys[] = {
 		.power_on	= exynos4210_power_on,
 		.power_off	= exynos4210_power_off,
 	},
-	{},
 };
 
 const struct samsung_usb2_phy_config exynos4210_usb2_phy_config = {
drivers/phy/phy-exynos4x12-usb2.c +0 -1
index 0b9de88..765da90 100644
@@ -361,7 +361,6 @@ static const struct samsung_usb2_common_phy exynos4x12_phys[] = {
 		.power_on	= exynos4x12_power_on,
 		.power_off	= exynos4x12_power_off,
 	},
-	{},
 };
 
 const struct samsung_usb2_phy_config exynos3250_usb2_phy_config = {
drivers/phy/phy-exynos5250-usb2.c +0 -1
index 1c139aa..2ed1735 100644
@@ -391,7 +391,6 @@ static const struct samsung_usb2_common_phy exynos5250_phys[] = {
 		.power_on	= exynos5250_power_on,
 		.power_off	= exynos5250_power_off,
 	},
-	{},
 };
 
 const struct samsung_usb2_phy_config exynos5250_usb2_phy_config = {
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

From: Axel Lin [mailto:[email protected]]
Sent: Tuesday, March 03, 2015 2:09 AM

Quoted 5 lines

Current code uses num_phys settings to tell the number of entries in phys.
Thus remove the NULL terminating entry from phys array which is not necessary.

The patch looks good.

Quoted 1 line
Signed-off-by Axel Lin <[email protected]>
Acked-by Kamil Debski <[email protected]>

Best wishes,

Signature · 2 lines
Kamil Debski
Samsung R&D Institute Poland
Quoted 50 lines

---
drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12-
usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 -

 3 files changed, 3 deletions(-)
drivers/phy/phy- renamed from drivers/phy/phy-exynos4210-usb2.c +0 -0

exynos4210-usb2.c
index 236a52a..f30bbb0 100644

drivers/phy/phy-exynos4210-usb2.c +0 -1
@@ -250,7 +250,6 @@ static const struct samsung_usb2_common_phy
 exynos4210_phys[] = {
 		.power_on	= exynos4210_power_on,
 		.power_off	= exynos4210_power_off,
 	},
-	{},
 };

const struct samsung_usb2_phy_config exynos4210_usb2_phy_config = {

drivers/phy/phy- renamed from drivers/phy/phy-exynos4x12-usb2.c +0 -0

exynos4x12-usb2.c
index 0b9de88..765da90 100644

drivers/phy/phy-exynos4x12-usb2.c +0 -1
@@ -361,7 +361,6 @@ static const struct samsung_usb2_common_phy
 exynos4x12_phys[] = {
 		.power_on	= exynos4x12_power_on,
 		.power_off	= exynos4x12_power_off,
 	},
-	{},
 };

const struct samsung_usb2_phy_config exynos3250_usb2_phy_config = {

drivers/phy/phy- renamed from drivers/phy/phy-exynos5250-usb2.c +0 -0

exynos5250-usb2.c
index 1c139aa..2ed1735 100644

drivers/phy/phy-exynos5250-usb2.c +0 -1
@@ -391,7 +391,6 @@ static const struct samsung_usb2_common_phy
 exynos5250_phys[] = {
 		.power_on	= exynos5250_power_on,
 		.power_off	= exynos5250_power_off,
 	},
-	{},
 };

const struct samsung_usb2_phy_config exynos5250_usb2_phy_config = {
--
1.9.1