staging: lustre: remove initialization of static ints
PATCH 1/1 staging: lustre: remove initialization of static ints
static ints are initialized to 0 by the compiler.
Explicit initialization is not necessary.
Found by checkpatch.pl - ERROR: do not initialise statics to 0 or NULL
changes made using coccinelle script:
@@
type T;
identifier var;
@@
-static T var = 0;
+static T var;
Signed-off-by Supriya Karanth <[email protected]>
--- drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +- drivers/staging/lustre/lustre/libcfs/tracefile.c | 2 +- drivers/staging/lustre/lustre/llite/statahead.c | 2 +- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- drivers/staging/lustre/lustre/obdclass/genops.c | 2 +- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- drivers/staging/lustre/lustre/obdclass/lu_object.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +1 -1
@@ -165,7 +165,7 @@ static int proc_dobitmasks(struct ctl_table *table, int write, __proc_dobitmasks); } -static int min_watchdog_ratelimit =0 ;/* disable ratelimiting */ +static int min_watchdog_ratelimit;/* disable ratelimiting */ static int max_watchdog_ratelimit = (24 *60 *60 );/* limit to once per day */ static int __proc_dump_kernel(void *data, int write,
drivers/staging/lustre/lustre/libcfs/tracefile.c +1 -1
@@ -53,7 +53,7 @@ char cfs_tracefile[TRACEFILE_NAME_SIZE];long long cfs_tracefile_size =CFS_TRACEFILE_SIZE ;static struct tracefiled_ctl trace_tctl;struct mutex cfs_trace_thread_mutex; -static int thread_running =0 ; +static int thread_running;static atomic_t cfs_tage_allocated =ATOMIC_INIT (0 );
drivers/staging/lustre/lustre/llite/statahead.c +1 -1
@@ -84,7 +84,7 @@ struct ll_sa_entry {struct qstr se_qstr; }; -static unsigned int sai_generation =0 ; +static unsigned int sai_generation;static DEFINE_SPINLOCK (sai_generation_lock);static inline int ll_sa_entry_unhashed (struct ll_sa_entry *entry)
drivers/staging/lustre/lustre/mgc/mgc_request.c +1 -1
@@ -479,7 +479,7 @@ int lprocfs_mgc_rd_ir_state(struct seq_file *m, void *data)#define RQ_NOW 0x2#define RQ_LATER 0x4#define RQ_STOP 0x8 -static int rq_state =0 ; +static int rq_state;static wait_queue_head_t rq_waitq;static DECLARE_COMPLETION (rq_exit);
drivers/staging/lustre/lustre/obdclass/genops.c +1 -1
@@ -1559,7 +1559,7 @@ void obd_exports_barrier(struct obd_device *obd)EXPORT_SYMBOL (obd_exports_barrier);/* Total amount of zombies to be destroyed */ -static int zombies_count =0 ; +static int zombies_count;/** * kill zombie imports and exports
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +1 -1
@@ -223,7 +223,7 @@ EXPORT_SYMBOL(lprocfs_write_frac_helper);#if defined (CONFIG_PROC_FS ) -static int lprocfs_no_percpu_stats =0 ; +static int lprocfs_no_percpu_stats;module_param (lprocfs_no_percpu_stats, int,0644 );MODULE_PARM_DESC (lprocfs_no_percpu_stats,"Do not alloc percpu data for lprocfs stats" );
drivers/staging/lustre/lustre/obdclass/lu_object.c +1 -1
@@ -1308,7 +1308,7 @@ static DEFINE_SPINLOCK(lu_keys_guard);* lu_context_refill(). No locking is provided, as initialization and shutdown * are supposed to be externally serialized. */ -static unsigned key_set_version =0 ; +static unsigned key_set_version;/** * Register new key.
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +1 -1
@@ -117,7 +117,7 @@ EXPORT_SYMBOL(lustre_msg_check_version);/* early reply size */ int lustre_msg_early_size (void ) { -static int size =0 ; +static int size;if (!size) {/* Always reply old ptlrpc_body_v2 to keep interoprability * with the old client (< 2.3) which doesn't have pb_jobid
drivers/staging/lustre/lustre/ptlrpc/pinger.c +1 -1
@@ -545,7 +545,7 @@ void ptlrpc_pinger_wake_up(void)#define PET_READY 1#define PET_TERMINATE 2 -static int pet_refcount =0 ; +static int pet_refcount;static int pet_state;static wait_queue_head_t pet_waitq;LIST_HEAD (pet_list);
drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c +1 -1
@@ -85,7 +85,7 @@ MODULE_PARM_DESC(ptlrpcd_bind_policy, "Ptlrpcd threads binding mode.");static struct ptlrpcd *ptlrpcds;struct mutex ptlrpcd_mutex; -static int ptlrpcd_users =0 ; +static int ptlrpcd_users;void ptlrpcd_wake (struct ptlrpc_request *req) {
Signature · 1 line
2.1.0
Review
Quoted 8 lines
changes made using coccinelle script:
@@
type T;
identifier var;
@@(quoted diff) +1
-1-static T var = 0; +static T var;
It probably doesn't matter in this case, but in general with Coccinelle, it is better not to remove code and then add it back, because when you add it back, it is the Coccinelle pretty printer that decides what to do? So you could write this with:
static T var
- = 0
;
julia
Quoted 155 lines
Signed-off-by Supriya Karanth <[email protected]>--- drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +- drivers/staging/lustre/lustre/libcfs/tracefile.c | 2 +- drivers/staging/lustre/lustre/llite/statahead.c | 2 +- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- drivers/staging/lustre/lustre/obdclass/genops.c | 2 +- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- drivers/staging/lustre/lustre/obdclass/lu_object.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +1
-1@@ -165,7 +165,7 @@ static int proc_dobitmasks(struct ctl_table *table, int write, __proc_dobitmasks); } -static int min_watchdog_ratelimit =0 ;/* disable ratelimiting */ +static int min_watchdog_ratelimit;/* disable ratelimiting */ static int max_watchdog_ratelimit = (24 *60 *60 );/* limit to once per day */ static int __proc_dump_kernel(void *data, int write,drivers/staging/lustre/lustre/libcfs/tracefile.c +1
-1@@ -53,7 +53,7 @@ char cfs_tracefile[TRACEFILE_NAME_SIZE];long long cfs_tracefile_size =CFS_TRACEFILE_SIZE ;static struct tracefiled_ctl trace_tctl;struct mutex cfs_trace_thread_mutex; -static int thread_running =0 ; +static int thread_running;static atomic_t cfs_tage_allocated =ATOMIC_INIT (0 );drivers/staging/lustre/lustre/llite/statahead.c +1
-1@@ -84,7 +84,7 @@ struct ll_sa_entry {struct qstr se_qstr; }; -static unsigned int sai_generation =0 ; +static unsigned int sai_generation;static DEFINE_SPINLOCK (sai_generation_lock);static inline int ll_sa_entry_unhashed (struct ll_sa_entry *entry)drivers/staging/lustre/lustre/mgc/mgc_request.c +1
-1@@ -479,7 +479,7 @@ int lprocfs_mgc_rd_ir_state(struct seq_file *m, void *data)#define RQ_NOW 0x2#define RQ_LATER 0x4#define RQ_STOP 0x8 -static int rq_state =0 ; +static int rq_state;static wait_queue_head_t rq_waitq;static DECLARE_COMPLETION (rq_exit);drivers/staging/lustre/lustre/obdclass/genops.c +1
-1@@ -1559,7 +1559,7 @@ void obd_exports_barrier(struct obd_device *obd)EXPORT_SYMBOL (obd_exports_barrier);/* Total amount of zombies to be destroyed */ -static int zombies_count =0 ; +static int zombies_count;/** * kill zombie imports and exports drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +1
-1@@ -223,7 +223,7 @@ EXPORT_SYMBOL(lprocfs_write_frac_helper);#if defined (CONFIG_PROC_FS ) -static int lprocfs_no_percpu_stats =0 ; +static int lprocfs_no_percpu_stats;module_param (lprocfs_no_percpu_stats, int,0644 );MODULE_PARM_DESC (lprocfs_no_percpu_stats,"Do not alloc percpu data for lprocfs stats" );drivers/staging/lustre/lustre/obdclass/lu_object.c +1
-1@@ -1308,7 +1308,7 @@ static DEFINE_SPINLOCK(lu_keys_guard);* lu_context_refill(). No locking is provided, as initialization and shutdown * are supposed to be externally serialized. */ -static unsigned key_set_version =0 ; +static unsigned key_set_version;/** * Register new key. drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +1
-1@@ -117,7 +117,7 @@ EXPORT_SYMBOL(lustre_msg_check_version);/* early reply size */ int lustre_msg_early_size (void ) { -static int size =0 ; +static int size;if (!size) {/* Always reply old ptlrpc_body_v2 to keep interoprability * with the old client (< 2.3) which doesn't have pb_jobid drivers/staging/lustre/lustre/ptlrpc/pinger.c +1
-1@@ -545,7 +545,7 @@ void ptlrpc_pinger_wake_up(void)#define PET_READY 1#define PET_TERMINATE 2 -static int pet_refcount =0 ; +static int pet_refcount;static int pet_state;static wait_queue_head_t pet_waitq;LIST_HEAD (pet_list);drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c +1
-2@@ -85,7 +85,7 @@ MODULE_PARM_DESC(ptlrpcd_bind_policy, "Ptlrpcd threads binding mode.");static struct ptlrpcd *ptlrpcds;struct mutex ptlrpcd_mutex; -static int ptlrpcd_users =0 ; +static int ptlrpcd_users;void ptlrpcd_wake (struct ptlrpc_request *req) { --2.1.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425394101-8180-1-git-send-email-iskaranth%40gmail.com.
For more options, visit https://groups.google.com/d/optout.