Skip to contentSkip to conversation

tegra: Remove tegra_spl_gpio_direction_output declaration from header file

PATCH Superseded Axel Lin 3 participants 4 messages Mar 5, 2015

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 tegra: Remove tegra_spl_gpio_direction_output declaration from header file

This function is deleted by commit 2fccd2d96bad "tegra: Convert tegra GPIO driver to use driver model".

---
 arch/arm/include/asm/arch-tegra/gpio.h | 9 ---------
 1 file changed, 9 deletions(-)
arch/arm/include/asm/arch-tegra/gpio.h +0 -9
index 7334e0c..daf5698 100644
@@ -28,15 +28,6 @@ struct tegra_gpio_config {
 };
 
 /**
- * tegra_spl_gpio_direction_output() - set the output value of a GPIO
- *
- * This function is only used from SPL on seaboard, which needs to enable a
- * GPIO to get the UART running. It could be done in U-Boot rather than SPL,
- * but for now, this gets it working
- */
-int tegra_spl_gpio_direction_output(int gpio, int value);
-
-/**
  * Configure a list of GPIOs
  *
  * @param config	List of GPIO configurations
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 tegra: Remove tegra_spl_gpio_direction_output declaration from header file

Quoted 2 lines · Axel Lin

This function is deleted by commit 2fccd2d96bad "tegra: Convert tegra GPIO driver to use driver model".

I think you want to send this to Tom Warren (who as Tegra maintainer would apply it) and whoever wrote the commit you're fixing (Simon Glass I would assume given the description). I've CC'd them so they see the patch.

Quoted 27 lines
---
  arch/arm/include/asm/arch-tegra/gpio.h | 9 ---------
  1 file changed, 9 deletions(-)
arch/arm/include/asm/arch-tegra/gpio.h +0 -9
index 7334e0c..daf5698 100644
@@ -28,15 +28,6 @@ struct tegra_gpio_config {
  };
 
  /**
- * tegra_spl_gpio_direction_output() - set the output value of a GPIO
- *
- * This function is only used from SPL on seaboard, which needs to enable a
- * GPIO to get the UART running. It could be done in U-Boot rather than SPL,
- * but for now, this gets it working
- */
-int tegra_spl_gpio_direction_output(int gpio, int value);
-
-/**
   * Configure a list of GPIOs
   *
   * @param config	List of GPIO configurations
#2 lore raw

PATCH 1/1 tegra: Remove tegra_spl_gpio_direction_output declaration from header file

Quoted 43 lines · Stephen Warren
Quoted 3 lines · Axel Lin

This function is deleted by commit 2fccd2d96bad "tegra: Convert tegra GPIO driver to use driver model".

I think you want to send this to Tom Warren (who as Tegra maintainer would apply it) and whoever wrote the commit you're fixing (Simon Glass I would assume given the description). I've CC'd them so they see the patch.

Quoted 30 lines
---
  arch/arm/include/asm/arch-tegra/gpio.h | 9 ---------
  1 file changed, 9 deletions(-)
arch/arm/include/asm/arch-tegra/gpio.h +0 -3
index 7334e0c..daf5698 100644
@@ -28,15 +28,6 @@ struct tegra_gpio_config {
  };
 
  /**
- * tegra_spl_gpio_direction_output() - set the output value of a GPIO
- *
- * This function is only used from SPL on seaboard, which needs to enable

a
- * GPIO to get the UART running. It could be done in U-Boot rather than SPL,
- * but for now, this gets it working
- */

arch/arm/include/asm/arch-tegra/gpio.h +0 -3
-int tegra_spl_gpio_direction_output(int gpio, int value);
-
-/**
   * Configure a list of GPIOs
   *
   * @param config      List of GPIO configurations
#3 lore raw

PATCH 1/1 tegra: Remove tegra_spl_gpio_direction_output declaration from header file

Quoted 44 lines · Simon Glass
Quoted 43 lines · Stephen Warren
Quoted 3 lines · Axel Lin

This function is deleted by commit 2fccd2d96bad "tegra: Convert tegra GPIO driver to use driver model".

I think you want to send this to Tom Warren (who as Tegra maintainer would apply it) and whoever wrote the commit you're fixing (Simon Glass I would assume given the description). I've CC'd them so they see the patch.

Quoted 30 lines
---
  arch/arm/include/asm/arch-tegra/gpio.h | 9 ---------
  1 file changed, 9 deletions(-)
arch/arm/include/asm/arch-tegra/gpio.h +0 -3
index 7334e0c..daf5698 100644
@@ -28,15 +28,6 @@ struct tegra_gpio_config {
  };
 
  /**
- * tegra_spl_gpio_direction_output() - set the output value of a GPIO
- *
- * This function is only used from SPL on seaboard, which needs to enable

a
- * GPIO to get the UART running. It could be done in U-Boot rather than SPL,
- * but for now, this gets it working
- */

arch/arm/include/asm/arch-tegra/gpio.h +0 -3
-int tegra_spl_gpio_direction_output(int gpio, int value);
-
-/**
   * Configure a list of GPIOs
   *
   * @param config      List of GPIO configurations