Skip to contentSkip to conversation

C6x: time: Ensure consistency in __init

PATCH In review Nishanth Menon 2 participants 3 messages Mar 7, 2015 – Mar 26, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 C6x: time: Ensure consistency in __init

time_init invokes timer64_init (which is __init annotation) since all of these are invoked at init time, lets maintain consistency by ensuring time_init is marked appropriately as well.

This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y

WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init() The function time_init() references
the function __init timer64_init().
This is often because time_init lacks a __init
annotation or the annotation of timer64_init is wrong.

Fixes 546a39546c64 ("C6X: time management")

---

Newbie warning: this is my first foray at c6x, So, appreciate a little gentleness while killing me ;)

Applies on latest master:
af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux

 arch/c6x/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/c6x/kernel/time.c +1 -1
index 356ee84cad95..04845aaf5985 100644
@@ -49,7 +49,7 @@ u64 sched_clock(void)
 	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
 }
 
-void time_init(void)
+void __init time_init(void)
 {
 	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
 
Signature · 1 line
1.9.1
#1 lore raw

Hi,

Quoted 15 lines · Nishanth Menon

time_init invokes timer64_init (which is __init annotation) since all of these are invoked at init time, lets maintain consistency by ensuring time_init is marked appropriately as well.

This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y

WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init() The function time_init() references
the function __init timer64_init().
This is often because time_init lacks a __init
annotation or the annotation of timer64_init is wrong.

Fixes 546a39546c64 ("C6X: time management")
Quoted 8 lines

---

Newbie warning: this is my first foray at c6x, So, appreciate a little gentleness while killing me ;)

Applies on latest master:
af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux

Gentle ping.

Quoted 10 lines
 arch/c6x/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/c6x/kernel/time.c +0 -0
index 356ee84cad95..04845aaf5985 100644

arch/c6x/kernel/time.c u64 sched_clock(void) · line 55

Quoted 8 lines
arch/c6x/kernel/time.c +1 -1
@@ -49,7 +49,7 @@ u64 sched_clock(void)
 	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
 }
 
-void time_init(void)
+void __init time_init(void)
 {
 	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
 

--
Regards,
Nishanth Menon

#2 lore raw
Quoted 20 lines · Nishanth Menon

Hi,

Quoted 17 lines · Nishanth Menon

time_init invokes timer64_init (which is __init annotation) since all of these are invoked at init time, lets maintain consistency by ensuring time_init is marked appropriately as well.

This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y

WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init() The function time_init() references
the function __init timer64_init().
This is often because time_init lacks a __init
annotation or the annotation of timer64_init is wrong.

Fixes 546a39546c64 ("C6X: time management")

---

Quoted 8 lines
Quoted 6 lines

Newbie warning: this is my first foray at c6x, So, appreciate a little gentleness while killing me ;)

Applies on latest master:
af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux

Gentle ping.

Thanks! I added this to the c6x tree for next merge window.

Quoted 22 lines
Quoted 11 lines

 arch/c6x/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/c6x/kernel/time.c +0 -0
index 356ee84cad95..04845aaf5985 100644

arch/c6x/kernel/time.c u64 sched_clock(void) · line 55

Quoted 8 lines
arch/c6x/kernel/time.c +1 -1
@@ -49,7 +49,7 @@ u64 sched_clock(void)
 	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
 }
 
-void time_init(void)
+void __init time_init(void)
 {
 	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
 

--
Regards,
Nishanth Menon