Skip to contentSkip to conversation

ibmveth: enable interrupts after napi_complete()

PATCH In review Yongbae Park 2 participants 2 messages Mar 9, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ibmveth: enable interrupts after napi_complete()

The interrupt is enabled before napi_complete(). A network timeout occurs if the interrupt handler is called before napi_complete().

Fix the bug by enabling the interrupt after napi_complete().

---
 drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/ibm/ibmveth.c +2 -2
index 21978cc..edcb4c7 100644
@@ -1136,6 +1136,8 @@ restart_poll:
 	ibmveth_replenish_task(adapter);
 
 	if (frames_processed < budget) {
+		napi_complete(napi);
+
 		/* We think we are done - reenable interrupts,
 		 * then check once more to make sure we are done.
 		 */
@@ -1144,8 +1146,6 @@ restart_poll:
 
 		BUG_ON(lpar_rc != H_SUCCESS);
 
-		napi_complete(napi);
-
 		if (ibmveth_rxq_pending_buffer(adapter) &&
 		    napi_reschedule(napi)) {
 			lpar_rc = h_vio_signal(adapter->vdev->unit_address,
Signature · 1 line
1.9.1
#1 lore raw

Yongbae,

Thank you for submitting the patch for this issue. Issues
with this device driver should be reported via [email protected]
and also please copy the maintainer of ibmveth, Thomas Falcon <[email protected]>.

Thanks!

Brian

Signature · 3 lines
Brian King
Power Linux I/O
IBM Linux Technology Center