dgnc: Remove unneeded dgnc_state array of strings
PATCH 1/3 dgnc: Remove unneeded dgnc_state array of strings
Dgnc_state array of strings is never used anywhere and it seems pretty useless anyway since the board state enum names speak for themselves.
--- drivers/staging/dgnc/dgnc_driver.c | 8 -------- drivers/staging/dgnc/dgnc_driver.h | 1 - 2 files changed, 9 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +0 -8
@@ -139,14 +139,6 @@ static struct pci_driver dgnc_driver = { .id_table = dgnc_pci_tbl, }; - -char *dgnc_state_text[] = { -"Board Failed" , -"Board Found" , -"Board READY" , -}; - -/************************************************************************ * * Driver load/unload functions
drivers/staging/dgnc/dgnc_driver.h +0 -1
@@ -403,6 +403,5 @@ extern int dgnc_poll_tick; /* Poll interval - 20 ms */extern spinlock_t dgnc_global_lock;/* Driver global spinlock */ extern uint dgnc_NumBoards;/* Total number of boards */ extern struct dgnc_board *dgnc_Board[MAXBOARDS ];/* Array of board structs */ -extern char *dgnc_state_text[];/* Array of state text */ #endif
Signature · 1 line
2.3.2
PATCH 2/3 dgnc: remove DGNC_VERIFY_BOARD macro
In sysfs methods struct device is guaranteed to not be NULL thus bd will not be NULL in any way. Also, checking for bd->magic != DGNC_BOARD_MAGIC and bd->state != BOARD_READY is redundant because we already don't initialize broken boards since "dgnc: Don't save boards in memory that have failed to initialize" and make sysfs files after initializing the board in dgnc_driver.c or IOW they are already set for successfully initialized boards before their sysfs files created (412 and 593 lines in dgnc_driver.c).
--- drivers/staging/dgnc/dgnc_sysfs.c | 96 ++++++++++----------------------------- 1 file changed, 23 insertions(+), 73 deletions(-)
drivers/staging/dgnc/dgnc_sysfs.c +23 -73
@@ -105,28 +105,10 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver)driver_remove_file (driverfs, &driver_attr_pollrate); } - -#define DGNC_VERIFY_BOARD (p, bd) \ - do { \ - if (!p) \ - return 0; \ - \ - bd = dev_get_drvdata(p); \ - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ - return 0; \ - if (bd->state != BOARD_READY) \ - return 0; \ - } while (0) - - -static ssize_t dgnc_vpd_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p); count +=sprintf (buf + count,"\n 0 1 2 3 4 5 6 7 8 9 A B C D E F" );for (i =0 ; i <0x40 *2 ; i++) {
@@ -142,10 +124,8 @@ static DEVICE_ATTR(vpd, S_IRUSR, dgnc_vpd_show, NULL);static ssize_t dgnc_serial_number_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd;int count =0 ; - -DGNC_VERIFY_BOARD (p, bd); +struct dgnc_board *bd =dev_get_drvdata (p);if (bd->serial_num[0 ] =='\0' ) count +=sprintf (buf + count,"<UNKNOWN>\n" );
@@ -159,11 +139,8 @@ static DEVICE_ATTR(serial_number, S_IRUSR, dgnc_serial_number_show, NULL);static ssize_t dgnc_ports_state_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count,
@@ -177,11 +154,8 @@ static DEVICE_ATTR(ports_state, S_IRUSR, dgnc_ports_state_show, NULL);static ssize_t dgnc_ports_baud_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count,
@@ -194,11 +168,8 @@ static DEVICE_ATTR(ports_baud, S_IRUSR, dgnc_ports_baud_show, NULL);static ssize_t dgnc_ports_msignals_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) {if (bd->channels[i]->ch_open_count) {
@@ -222,11 +193,8 @@ static DEVICE_ATTR(ports_msignals, S_IRUSR, dgnc_ports_msignals_show, NULL);static ssize_t dgnc_ports_iflag_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %x\n",
@@ -239,11 +207,8 @@ static DEVICE_ATTR(ports_iflag, S_IRUSR, dgnc_ports_iflag_show, NULL);static ssize_t dgnc_ports_cflag_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %x\n",
@@ -256,11 +221,8 @@ static DEVICE_ATTR(ports_cflag, S_IRUSR, dgnc_ports_cflag_show, NULL);static ssize_t dgnc_ports_oflag_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %x\n",
@@ -273,11 +235,8 @@ static DEVICE_ATTR(ports_oflag, S_IRUSR, dgnc_ports_oflag_show, NULL);static ssize_t dgnc_ports_lflag_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %x\n",
@@ -290,11 +249,8 @@ static DEVICE_ATTR(ports_lflag, S_IRUSR, dgnc_ports_lflag_show, NULL);static ssize_t dgnc_ports_digi_flag_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %x\n",
@@ -307,11 +263,8 @@ static DEVICE_ATTR(ports_digi_flag, S_IRUSR, dgnc_ports_digi_flag_show, NULL);static ssize_t dgnc_ports_rxcount_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %ld\n",
@@ -324,11 +277,8 @@ static DEVICE_ATTR(ports_rxcount, S_IRUSR, dgnc_ports_rxcount_show, NULL);static ssize_t dgnc_ports_txcount_show (struct device *p,struct device_attribute *attr,char *buf) { -struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ; +struct dgnc_board *bd =dev_get_drvdata (p);for (i =0 ; i < bd->nasync; i++) { count += snprintf(buf + count, PAGE_SIZE - count, "%d %ld\n",
Signature · 1 line
2.3.2
Re: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro
drivers/staging/dgnc/dgnc_sysfs.c void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) · line 110
Quoted 8 lines · Giedrius Statkevičius
static
ssize_tdgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf){drivers/staging/dgnc/dgnc_sysfs.c +1
-5-struct dgnc_board *bd; -int count =0 ; -int i =0 ; - -DGNC_VERIFY_BOARD (p, bd); +int count =0 , i =0 ;
Don't redo the patch, but really these should be on separate lines. This is an unwritten rule. :) Also there is no need to set "i".
regards,
dan carpenter
Greg KH
maintainerRe: [PATCH 2/3] dgnc: remove DGNC_VERIFY_BOARD macro
In reply to Giedrius StatkevičiusQuoted 8 lines · Giedrius Statkevičius
In sysfs methods struct device is guaranteed to not be NULL thus bd will not be NULL in any way. Also, checking for
bd->magic!=DGNC_BOARD_MAGICandbd->state!=BOARD_READYis redundant because we already don't initialize broken boards since "dgnc: Don't save boards in memory that have failed to initialize" and make sysfs files after initializing the board indgnc_driver.cor IOW they are already set for successfully initialized boards before their sysfs files created (412 and 593 lines indgnc_driver.c).
As I didn't take your previous patch that this relies on, I can't take this one at this point in time, sorry.
greg k-h
PATCH 3/3 dgnc: clean up comments at start of files
In reply to Giedrius StatkevičiusRemove FSF address because it's known in the past that it has changed. Also, remove the pointless "do not change the coding style" comments because it's one of the reasons why it's in staging and it's quite contradictory to what it says in TODO. Also, they contain wrong e-mails of people which are responsible for these drivers - see TODO or MAINTAINERS for that. We can preserve the original copyright at the top of the most files because it shows who originally made them.
--- drivers/staging/dgnc/dgnc_cls.c | 16 ---------------- drivers/staging/dgnc/dgnc_cls.h | 7 ------- drivers/staging/dgnc/dgnc_driver.c | 16 ---------------- drivers/staging/dgnc/dgnc_driver.h | 6 ------ drivers/staging/dgnc/dgnc_kcompat.h | 6 ------ drivers/staging/dgnc/dgnc_mgmt.c | 16 ---------------- drivers/staging/dgnc/dgnc_mgmt.h | 6 ------ drivers/staging/dgnc/dgnc_neo.c | 16 ---------------- drivers/staging/dgnc/dgnc_neo.h | 7 ------- drivers/staging/dgnc/dgnc_pci.h | 6 ------ drivers/staging/dgnc/dgnc_sysfs.c | 16 ---------------- drivers/staging/dgnc/dgnc_sysfs.h | 6 ------ drivers/staging/dgnc/dgnc_tty.c | 15 --------------- drivers/staging/dgnc/dgnc_tty.h | 6 ------ drivers/staging/dgnc/dgnc_types.h | 6 ------ drivers/staging/dgnc/digi.h | 6 ------ drivers/staging/dgnc/dpacompat.h | 6 ------ 17 files changed, 163 deletions(-)
drivers/staging/dgnc/dgnc_cls.c +0 -16
@@ -11,22 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. -* */ #include <linux/kernel.h>
drivers/staging/dgnc/dgnc_cls.h +0 -7
@@ -11,13 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! -* */ #ifndef __DGNC_CLS_H
drivers/staging/dgnc/dgnc_driver.c +0 -16
@@ -11,22 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. -* */
drivers/staging/dgnc/dgnc_driver.h +0 -6
@@ -12,12 +12,6 @@* implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. * -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! -* ************************************************************************* * * Driver includes
drivers/staging/dgnc/dgnc_kcompat.h +0 -6
@@ -12,12 +12,6 @@* implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. * -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! -* ************************************************************************* * * This file is intended to contain all the kernel "differences" between the
drivers/staging/dgnc/dgnc_mgmt.c +0 -16
@@ -11,22 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. -* */ /************************************************************************
drivers/staging/dgnc/dgnc_mgmt.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DGNC_MGMT_H
drivers/staging/dgnc/dgnc_neo.c +0 -16
@@ -11,22 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. -* */
drivers/staging/dgnc/dgnc_neo.h +0 -7
@@ -11,13 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! -* */ #ifndef __DGNC_NEO_H
drivers/staging/dgnc/dgnc_pci.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DGNC_PCI_H
drivers/staging/dgnc/dgnc_sysfs.c +0 -16
@@ -11,22 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. -* */
drivers/staging/dgnc/dgnc_sysfs.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DGNC_SYSFS_H
drivers/staging/dgnc/dgnc_tty.c +0 -15
@@ -11,21 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* -* NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! -* -* This is shared code between Digi's CVS archive and the -* Linux Kernel sources. -* Changing the source just for reformatting needlessly breaks -* our CVS diff history. -* -* Send any bug fixes/changes to: Eng.Linux at digi dot com. -* Thank you. */ /************************************************************************
drivers/staging/dgnc/dgnc_tty.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DGNC_TTY_H
drivers/staging/dgnc/dgnc_types.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DGNC_TYPES_H
drivers/staging/dgnc/digi.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */ #ifndef __DIGI_H
drivers/staging/dgnc/dpacompat.h +0 -6
@@ -11,12 +11,6 @@* but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR * PURPOSE. See the GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -* -* NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!! */
Signature · 1 line
2.3.2