Skip to contentSkip to conversation

phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

PATCH In review Axel Lin 2 participants 2 messages Mar 11, 2015 – Mar 12, 2015

Subsystems (2)
Arm Samsung Exynos Generic PHY framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

Remove the second lock on non-regmap path.

Fixes 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
Reported-by Julia Lawall <[email protected]>
Signed-off-by Axel Lin <[email protected]>
---
 drivers/phy/phy-exynos-mipi-video.c | 1 -
 1 file changed, 1 deletion(-)
drivers/phy/phy-exynos-mipi-video.c +0 -1
index 8d6d117..df7519a 100644
@@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
 	} else {
 		addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
 
-		spin_lock(&state->slock);
 		val = readl(addr);
 		if (on)
 			val |= reset;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Axel Lin

Remove the second lock on non-regmap path.

Fixes 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
Reported-by Julia Lawall <[email protected]>
Signed-off-by Axel Lin <[email protected]>

merged after squashing it with the original patch.

Thanks
Kishon

Quoted 17 lines
---
  drivers/phy/phy-exynos-mipi-video.c | 1 -
  1 file changed, 1 deletion(-)
drivers/phy/phy-exynos-mipi-video.c +0 -1
index 8d6d117..df7519a 100644
@@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
  	} else {
  		addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
 
-		spin_lock(&state->slock);
  		val = readl(addr);
  		if (on)
  			val |= reset;