Skip to contentSkip to conversation

kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h

PATCH Andrew Morton 1 participant 1 message Mar 12, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 8 lines · On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause <[email protected]> wrote:

This fixes the function definiton of do_exit to comply with its function prototype as defined in kernel.h as found when running sparse on the latest updated version of the mainline kernel.

...

(quoted diff) +1 -1
-void do_exit(long code)
+void do_exit(long error_code)

We still have

include/linux/module.h:#define module_put_and_exit(code) do_exit(code)

Probably changing the header files is the way to go - error_code is a bit of a mouthful.

Actually, using "exit_code" everywhere would be best - that's what the thing does, and it gets copied into task_struct.exit_code.

And change complete_and_exit(code).

do_group_exit() already uses exit_code.

sys_exit_group() uses "error_code".

It's rather a little mess we've made in there!