mmc: sdhci-esdhc-imx: Call mmc_of_parse()

PATCH Applied Fabio Estevam 2 participants 2 messages Mar 12, 2015 – Mar 13, 2015

Subsystems (4)

Arm i.MX and Layerscape MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Secure digital host controller interface (SDHCI) NXP i.MX driver

lore

Share & tools

lore

Fabio Estevam

author reviewer

2015-03-12 22:15 UTC #0 lore raw

PATCH 1/1 mmc: sdhci-esdhc-imx: Call mmc_of_parse()

From: Fabio Estevam <[email protected]>

Currently it is not possible to use 'mmc-pwrseq-simple' property with this driver because mmc_of_parse() is never called.

mmc_of_parse() calls mmc_pwrseq_alloc() that manages MMC power sequence.

Call the generic mmc_of_parse() so that we can use 'mmc-pwrseq-simple' to provide reset GPIO to the Wifi/BT chip.

Tested on a imx6sl-warp board.

Signed-off-by Fabio Estevam <[email protected]>

---
 drivers/mmc/host/sdhci-esdhc-imx.c | 5 +++++
 1 file changed, 5 insertions(+)

drivers/mmc/host/sdhci-esdhc-imx.c +5 -0

index 9cce5cf..d714d8f 100644
@@ -1075,6 +1075,11 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
 		host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
 	}
 
+	/* call to generic mmc_of_parse to support additional capabilities */
+	err = mmc_of_parse(host->mmc);
+	if (err)
+		goto disable_clk;
+
 	err = sdhci_add_host(host);
 	if (err)
 		goto disable_clk;

Signature · 1 line

1.9.1

Ulf Hansson

Applied

2015-03-13 10:15 UTC #1 lore raw

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Currently it is not possible to use 'mmc-pwrseq-simple' property with this driver because mmc_of_parse() is never called.

Quoted 8 lines

mmc_of_parse() calls mmc_pwrseq_alloc() that manages MMC power sequence.
Call the generic mmc_of_parse() so that we can use 'mmc-pwrseq-simple' to provide reset GPIO to the Wifi/BT chip.
Tested on a imx6sl-warp board.
Signed-off-by Fabio Estevam <[email protected]>

Thanks, applied!

Kind regards
Uffe

Quoted 23 lines

---
 drivers/mmc/host/sdhci-esdhc-imx.c | 5 +++++
 1 file changed, 5 insertions(+)

drivers/mmc/host/sdhci-esdhc-imx.c +5 -1

index 9cce5cf..d714d8f 100644
@@ -1075,6 +1075,11 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
                host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
        }
 
+       /* call to generic mmc_of_parse to support additional capabilities */
+       err = mmc_of_parse(host->mmc);
+       if (err)
+               goto disable_clk;
+
        err = sdhci_add_host(host);
        if (err)
                goto disable_clk;
--

1.9.1