xen-blkback: enlarge the array size of blkback name
Subsystems (2)
PATCH 1/1 xen-blkback: enlarge the array size of blkback name
The blkback name is like blkback.domid.xvd[a-z], if domid has three digits (means larger than 100), then the backmost xvd wouldn't be fully shown.
Define a BLKBACK_NAME_LEN macro which is (TASK_COMM_LEN * 2), enlarge the array size of blkback name, so it will be fully shown in any case.
--- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/block/xen-blkback/xenbus.c +5 -2
@@ -21,6 +21,9 @@#include <xen/grant_table.h> #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2) +struct backend_info {struct xenbus_device *dev;struct xen_blkif *blkif;
@@ -70,7 +73,7 @@ static int blkback_name(struct xen_blkif *blkif, char *buf)else devname = devpath; -snprintf (buf,TASK_COMM_LEN ,"blkback.%d.%s" , blkif->domid, devname); +snprintf (buf,BLKBACK_NAME_LEN ,"blkback.%d.%s" , blkif->domid, devname);kfree (devpath);return 0 ;
@@ -79,7 +82,7 @@ static int blkback_name(struct xen_blkif *blkif, char *buf)static void xen_update_blkif_status (struct xen_blkif *blkif) {int err; -char name[TASK_COMM_LEN ]; +char name[BLKBACK_NAME_LEN ];/* Not ready to connect? */ if (!blkif->irq || !blkif->vbd.bdev)
Signature · 1 line
1.8.5
El 13/03/15 a les 16.52, Tao Chen ha escrit:
Quoted 16 lines
The blkback name is like blkback.domid.xvd[a-z], if domid has three digits (means larger than 100), then the backmost xvd wouldn't be fully shown.
Define a
BLKBACK_NAME_LENmacro which is (TASK_COMM_LEN* 2), enlarge the array size of blkback name, so it will be fully shown in any case.Signed-off-by Tao Chen <[email protected]>--- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/block/xen-blkback/xenbus.c +0
-0
drivers/block/xen-blkback/xenbus.c line 25
Quoted 5 lines
drivers/block/xen-blkback/xenbus.c +2
-0@@ -21,6 +21,9 @@#include <xen/grant_table.h> #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2)
Any reason to use TASK_COMM_LEN instead of just coding it to 17? Or maybe 20 to be on the safe side?
Roger.
You are right, roger. Thanks.
domid is a u16, it will occupy 5 characters at most. So the biggest length of blkback name is 8+5+5=18.
At this situation, define BLKBACK_NAME_LEN macro to be 20 is safe.
Quoted 30 lines · Roger Pau Monné
El 13/03/15 a les 16.52, Tao Chen ha escrit:
Quoted 16 lines
The blkback name is like blkback.domid.xvd[a-z], if domid has three digits (means larger than 100), then the backmost xvd wouldn't be fully shown.
Define a
BLKBACK_NAME_LENmacro which is (TASK_COMM_LEN* 2), enlarge the array size of blkback name, so it will be fully shown in any case.Signed-off-by Tao Chen <[email protected]>--- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/block/xen-blkback/xenbus.c +0
-0drivers/block/xen-blkback/xenbus.c line 25
Quoted 5 lines
drivers/block/xen-blkback/xenbus.c +2
-0@@ -21,6 +21,9 @@#include <xen/grant_table.h> #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2)Any reason to use
TASK_COMM_LENinstead of just coding it to 17? Or maybe 20 to be on the safe side?Roger.
.
You are right, roger. Thanks.
domid is a u16, it will occupy 5 characters at most. So the biggest length of blkback name is 8+5+5=18.
At this situation, define BLKBACK_NAME_LEN macro to be 20 is safe.
Quoted 30 lines · Roger Pau Monné
El 13/03/15 a les 16.52, Tao Chen ha escrit:
Quoted 16 lines
The blkback name is like blkback.domid.xvd[a-z], if domid has three digits (means larger than 100), then the backmost xvd wouldn't be fully shown.
Define a
BLKBACK_NAME_LENmacro which is (TASK_COMM_LEN* 2), enlarge the array size of blkback name, so it will be fully shown in any case.Signed-off-by Tao Chen <[email protected]>--- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/block/xen-blkback/xenbus.c +0
-0drivers/block/xen-blkback/xenbus.c line 25
Quoted 5 lines
drivers/block/xen-blkback/xenbus.c +2
-0@@ -21,6 +21,9 @@#include <xen/grant_table.h> #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2)Any reason to use
TASK_COMM_LENinstead of just coding it to 17? Or maybe 20 to be on the safe side?Roger.
.
El 13/03/15 a les 16.52, Tao Chen ha escrit:
Quoted 16 lines
The blkback name is like blkback.domid.xvd[a-z], if domid has three digits (means larger than 100), then the backmost xvd wouldn't be fully shown.
Define a
BLKBACK_NAME_LENmacro which is (TASK_COMM_LEN* 2), enlarge the array size of blkback name, so it will be fully shown in any case.Signed-off-by Tao Chen <[email protected]>--- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/block/xen-blkback/xenbus.c +0
-0
drivers/block/xen-blkback/xenbus.c line 25
Quoted 5 lines
drivers/block/xen-blkback/xenbus.c +2
-0@@ -21,6 +21,9 @@#include <xen/grant_table.h> #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (TASK_COMM_LEN * 2)
Any reason to use TASK_COMM_LEN instead of just coding it to 17? Or maybe 20 to be on the safe side?
Roger.