Skip to contentSkip to conversation

perf/builtin-diff: remove unnecessary error output

PATCH New Alexander Kuleshov 1 participant 1 message Mar 13, 2015 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf/builtin-diff: remove unnecessary error output

This patch prevents duplicated error output. per_session__new function calls perf_data_file__open which will print error message if it can not open the file and we will get duplicated output of the error message:

failed to open perf.data.old: No such file or directory Failed to open perf.data.old

---
 tools/perf/builtin-diff.c | 1 -
 1 file changed, 1 deletion(-)
tools/perf/builtin-diff.c +0 -1
index 74aada5..a18bf98 100644
@@ -742,7 +742,6 @@ static int __cmd_diff(void)
 	data__for_each_file(i, d) {
 		d->session = perf_session__new(&d->file, false, &tool);
 		if (!d->session) {
-			pr_err("Failed to open %s\n", d->file.path);
 			ret = -1;
 			goto out_delete;
 		}
Signature · 1 line
2.3.1.291.g7a9409c