Skip to contentSkip to conversation

pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type

PATCH In review Axel Lin 1 participant 2 messages Mar 14, 2015

Subsystems (4)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type

Fix a typo when checking level trigger irq type.

---
Hi Hongzhou,
This looks like a typo, but I don't have the datasheet so please confirm if this patch is correct or not.

 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +1 -1
index 493294c..cc27929 100644
@@ -934,7 +934,7 @@ static int mtk_eint_set_type(struct irq_data *d,
 	else
 		pctl->eint_dual_edges[d->hwirq] = 0;
 
-	if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING)) {
+	if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) {
 		reg = mtk_eint_get_offset(pctl, d->hwirq,
 			eint_offsets->pol_clr);
 		writel(mask, reg);
Signature · 1 line
1.9.1
author
#1 lore raw

2015-03-14 15:15 GMT+08:00 Axel Lin <[email protected]>:

Quoted 1 line

Fix a typo when checking level trigger irq type.

Sorry. I take it back, current code should be correct.

Regards,
Axel