Skip to contentSkip to conversation

remove pointless early_printk call in x86/kernel/head64.c

RFC PATCH New Alexander Kuleshov 2 participants 3 messages Mar 17, 2015 x86

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 remove pointless early_printk call in x86/kernel/head64.c

There is the call of the early_printk function in the x86/kernel/head64.c, but if i understand correctly early_printk initialized by setup_early_printk which is early_param, but early_param initialized only in the init/main.c in the do_early_param function. So early_printk from the x86/kernel/head64.c will not print anything in any case.

Alexander Kuleshov (1):
x86/head64.c: remove pointless early_printk call

 arch/x86/kernel/head64.c | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
2.3.3.472.g20ceeac.dirty
#1 lore raw

PATCH 1/1 x86/head64.c: remove pointless early_printk call

earlyprintk not initialised yet by the setup_early_printk so we can remove it.

---
 arch/x86/kernel/head64.c | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/kernel/head64.c +0 -3
index c4f8d46..2b55ee6 100644
@@ -177,9 +177,6 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
 	 */
 	load_ucode_bsp();
 
-	if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
-		early_printk("Kernel alive\n");
-
 	clear_page(init_level4_pgt);
 	/* set init_level4_pgt kernel high mapping*/
 	init_level4_pgt[511] = early_level4_pgt[511];
Signature · 1 line
2.3.3.472.g20ceeac.dirty
#2 lore raw

[tip:x86/boot] x86/boot/64: Remove pointless early_printk() message

x86/boot/64: Remove pointless early_printk() message
Commit-ID:  91d8f0416f3989e248d3a3d3efb821eda10a85d2
Gitweb:     http://git.kernel.org/tip/91d8f0416f3989e248d3a3d3efb821eda10a85d2
Author:     Alexander Kuleshov <[email protected]>
AuthorDate: Tue, 17 Mar 2015 19:00:05 +0600
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 17 Mar 2015 14:03:04 +0100

x86/boot/64: Remove pointless early_printk() message

earlyprintk is not initialised yet by the setup_early_printk() function so we can remove it.

---
 arch/x86/kernel/head64.c | 3 ---
 1 file changed, 3 deletions(-)
arch/x86/kernel/head64.c +0 -3
index eda1a86..8c58135 100644
@@ -172,9 +172,6 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
 	 */
 	load_ucode_bsp();
 
-	if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
-		early_printk("Kernel alive\n");
-
 	clear_page(init_level4_pgt);
 	/* set init_level4_pgt kernel high mapping*/
 	init_level4_pgt[511] = early_level4_pgt[511];