Skip to contentSkip to conversation

drm/i915: Remove unused variable in i915_gem_obj_ggtt_offset_view

PATCH In review Tvrtko Ursulin 3 participants 4 messages Mar 17, 2015 – Apr 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: Remove unused variable in i915_gem_obj_ggtt_offset_view

From: Tvrtko Ursulin <[email protected]>

---
 drivers/gpu/drm/i915/i915_gem.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +0 -1
index e2876bf..cc8672a 100644
@@ -5260,7 +5260,6 @@ unsigned long
 i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
 			      enum i915_ggtt_view_type view)
 {
-	struct drm_i915_private *dev_priv = o->base.dev->dev_private;
 	struct i915_address_space *ggtt = i915_obj_to_ggtt(o);
 	struct i915_vma *vma;
 
Signature · 6 lines
2.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915: Log view type when printing warnings

From: Tvrtko Ursulin <[email protected]>

It may save someone a bit of debugging time one day.

---
 drivers/gpu/drm/i915/i915_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +1 -1
index cc8672a..e150038 100644
@@ -5267,7 +5267,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
 		if (vma->vm == ggtt && vma->ggtt_view.type == view)
 			return vma->node.start;
 
-	WARN(1, "global vma for this object not found.\n");
+	WARN(1, "global vma for this object not found. (view=%u)\n", view);
 	return -1;
 }
 
Signature · 6 lines
2.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/i915: Log view type when printing warnings

Task id: 5984 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -1 268/268 267/268

ILK                                  303/303              303/303
SNB                                  283/283              283/283
IVB                                  343/343              343/343
BYT                                  287/287              287/287
HSW                                  363/363              363/363
BDW                                  308/308              308/308

-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gem_userptr_blits_minor-sync-interruptible PASS(2) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] drm/i915: Log view type when printing warnings

In reply to Tvrtko Ursulin

I ended up needing this bit too, so maybe better have it committed.

Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

It may save someone a bit of debugging time one day.

Quoted 10 lines
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +0 -0
index cc8672a..e150038 100644

drivers/gpu/drm/i915/i915_gem.c i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o, · line 5273

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -1
@@ -5267,7 +5267,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
 		if (vma->vm == ggtt && vma->ggtt_view.type == view)
 			return vma->node.start;
 
-	WARN(1, "global vma for this object not found.\n");
+	WARN(1, "global vma for this object not found. (view=%u)\n", view);
 	return -1;
 }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx