Intel: ASoC: Add condition check before set param to waves
Subsystems (3)
PATCH 1/1 Intel: ASoC: Add condition check before set param to waves
From: "Lu, Han" <[email protected]>
Check waves state before set parameter through ipc to prevent unexpected operation. Also remove redundant check.
Signed-off-by Lu, Han <[email protected]>
sound/soc/intel/sst-haswell-ipc.c +5 -0
@@ -2055,6 +2055,11 @@ int sst_hsw_launch_param_buf(struct sst_hsw *hsw) {int ret, idx; +if (!sst_hsw_is_module_active (hsw,SST_HSW_MODULE_WAVES )) { +dev_dbg (hsw->dev,"module waves is not active\n" ); +return 0 ; + } +/* put all param lines to DSP through ipc */ for (idx =0 ; idx < hsw->param_idx_w; idx++) { ret = sst_hsw_module_set_param(hsw,
sound/soc/intel/sst-haswell-pcm.c +1 -5
@@ -399,13 +399,9 @@ static int hsw_waves_param_put(struct snd_kcontrol *kcontrol,if (ret <0 )return ret; -if (sst_hsw_is_module_loaded (hsw, id)) { -if (!sst_hsw_is_module_active (hsw, id)) -return 0 ; - +if (sst_hsw_is_module_active (hsw, id)) ret =sst_hsw_module_set_param (hsw, id,0 , param_id, param_size, ucontrol->value.bytes.data); - }return ret; }
Signature · 1 line
1.9.1
Quoted 4 lines · On Thu, Mar 19, 2015 at 08:38:00AM +0800, [email protected] wrote:
From: "Lu, Han" <[email protected]>
Check waves state before set parameter through ipc to prevent unexpected operation. Also remove redundant check.
Applied, thanks.