Skip to contentSkip to conversation

mei: fix regression on NFC connection

char-misc Tomas Winkler 1 participant 1 message Mar 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

In mei_host_client_init function we enable the all internal connected clients including NFC. This is done before we set the device to enabled state and let userspace call open.
We need to check only for MEI_FILE_CONNECTED in mei_cl_is_connected in order to enable the communication with the clients before MEI_DEV_ENABLED is set.

---
 drivers/misc/mei/client.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/misc/mei/client.h +1 -3
index eb02f34b2fe0..7800d1bd8ba1 100644
@@ -92,9 +92,7 @@ int mei_cl_flow_ctrl_reduce(struct mei_cl *cl);
  */
 static inline bool mei_cl_is_connected(struct mei_cl *cl)
 {
-	return  cl->dev &&
-		cl->dev->dev_state == MEI_DEV_ENABLED &&
-		cl->state == MEI_FILE_CONNECTED;
+	return  cl->state == MEI_FILE_CONNECTED;
 }
 static inline bool mei_cl_is_transitioning(struct mei_cl *cl)
 {
Signature · 1 line
1.9.3