Input: synaptics - quirk for Thinkpad E440
Subsystems (2)
PATCH 1/1 Input: synaptics - quirk for Thinkpad E440
Its ClickPad shares PNP ID "LEN2006" with the one in model E540 which is already handled by the driver (both are Haswell iterations of the Edge line, launched in 2014) but the dimensions it reports are different:
$ sudo ./touchpad-edge-detector /dev/input/event3 Touchpad SynPS/2 Synaptics TouchPad on /dev/input/event3 Move one finger around the touchpad to detect the actual edges Kernel says: x [1472..5044], y [1408..3398] Touchpad sends: x [1024..5045], y [2457..4832] /^C
Fortunately we can use the board ID, which is also different, to distinguish among them.
$ dmesg | grep -i synaptics
psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1,
caps: 0xd001a3/0x940300/0x127c00, board id: 2691, fw id: 1494646
psmouse serio1: synaptics: serio: Synaptics pass-through port at
isa0060/serio1/input0
input: SynPS/2 Synaptics TouchPad as
/devices/platform/i8042/serio1/input/input4Board ID in E540 is 2722:
psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1,
caps: 0xd001a3/0x940300/0x127c00, board id: 2722, fw id: 1484859
(from https://launchpadlibrarian.net/179702965/BootDmesg.txt)
--- drivers/input/mouse/synaptics.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/input/mouse/synaptics.c +6 -1
@@ -154,6 +154,11 @@ static const struct min_max_quirk min_max_pnpid_table[] = { }, { (const char *const []){"LEN2006" ,NULL }, + {2691, 2691}, +1024 ,5045 ,2457 ,4632 + }, + { + (const char *const []){"LEN2006" ,NULL }, {ANY_BOARD_ID, ANY_BOARD_ID},1264 ,5675 ,1171 ,4688 },
@@ -189,7 +194,7 @@ static const char * const topbuttonpad_pnp_ids[] = {"LEN2003" ,"LEN2004" ,/* L440 */ "LEN2005" , -"LEN2006" , +"LEN2006" ,/* Edge E440/E540 */ "LEN2007" ,"LEN2008" , "LEN2009",
Signature · 1 line
1.9.1
Quoted 5 lines · Ramiro Morales
Subject: [PATCH] Input: synaptics - quirk for Thinkpad E440
Its ClickPad shares PNP ID "LEN2006" with the one in model E540 which is already handled by the driver (both are Haswell iterations of the Edge line, launched in 2014) but the dimensions it reports are different:
Clarification: This patch is against the synaptics branch.
Regards,
Signature · 1 line
Ramiro Morales
Quoted 9 lines · Ramiro Morales
Quoted 5 lines · Ramiro Morales
Subject: [PATCH] Input: synaptics - quirk for Thinkpad E440
Its ClickPad shares PNP ID "LEN2006" with the one in model E540 which is already handled by the driver (both are Haswell iterations of the Edge line, launched in 2014) but the dimensions it reports are different:
Clarification: This patch is against the synaptics branch.
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Cheers,
Benjamin
Quoted 9 lines
Regards,
--
Ramiro Morales
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Quoted 2 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Actually the laptop manufacturing date is Nov '13, I bought it on May.
This patch is almost a year late because I had a false start submitting fixes through the Ubuntu BTS[1] only to discover that a clashing quirk for the E540 got added upstream about the same time. The ability to include the board ID in the quirk table logic added by this branch provides a way out.
Quoted 3 lines
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Here it is:
https://dl.dropboxusercontent.com/u/5403630/dmesg_thinkpad_e440_synaptics_8f004f3f.txt
Regards,
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1395243
[2] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?id=bce4f9e764c36bc35dd5c9cf9e057c09f422397d
--
Ramiro Morales
Benjamin Tissoires
Reviewed-byQuoted 22 lines · Ramiro Morales
Quoted 6 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Quoted 2 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Actually the laptop manufacturing date is Nov '13, I bought it on May.
This patch is almost a year late because I had a false start submitting fixes through the Ubuntu BTS[1] only to discover that a clashing quirk for the E540 got added upstream about the same time. The ability to include the board ID in the quirk table logic added by this branch provides a way out.
Quoted 7 lines
Quoted 3 lines
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Here it is:
https://dl.dropboxusercontent.com/u/5403630/dmesg_thinkpad_e440_synaptics_8f004f3f.txt
Thanks for all these information. So indeed, your patch is entirely valid and is:
Cheers,
Benjamin
Quoted 13 lines
Regards,
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1395243
[2] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?id=bce4f9e764c36bc35dd5c9cf9e057c09f422397d--
Ramiro Morales
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 27 lines · Benjamin Tissoires
Quoted 26 lines · Ramiro Morales
Quoted 6 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Quoted 2 lines · Benjamin Tissoires
Then I am even more surprised that you need to quirk a late 2014 haswell refresh.
Actually the laptop manufacturing date is Nov '13, I bought it on May.
This patch is almost a year late because I had a false start submitting fixes through the Ubuntu BTS[1] only to discover that a clashing quirk for the E540 got added upstream about the same time. The ability to include the board ID in the quirk table logic added by this branch provides a way out.
Quoted 3 lines
Can you post your dmesg when booting the synaptics branch so that we can check if the FW has the correct values stored or if we really need to quirk it?
Quoted 7 lines
Quoted 3 lines
Here it is:
https://dl.dropboxusercontent.com/u/5403630/dmesg_thinkpad_e440_synaptics_8f004f3f.txt
Thanks for all these information. So indeed, your patch is entirely valid and is:
Reviewed-by Benjamin Tissoires <[email protected]>
Applied, thank you.
Quoted 17 lines
Cheers,
BenjaminQuoted 13 lines
Regards,
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1395243
[2] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?id=bce4f9e764c36bc35dd5c9cf9e057c09f422397d--
Ramiro Morales
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Dmitry