octeon-usb:Fix coding style issue with space between function name and opening bracket
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · Nicholas Krause
Fixes the checkpath.pl error where the opening bracket has a unneeded space between it and the function name for a if statement in the marco,VMX_WAIT_FOR_FIELD32.
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/octeon-usb/octeon-hcd.c +0
-0
drivers/staging/octeon-usb/octeon-hcd.c struct octeon_hcd { · line 415
Quoted 5 lines
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -412,7 +412,7 @@ struct octeon_hcd {type c; \while (1 ) { \ c.u32 =__cvmx_usb_read_csr32 (usb, address); \ - if (c.s.field op (value)) { \ + if (c.s.field op(value)) { \
"op" is not a function here. This is macro and top is an operation like "+" or "*". So checkpatch.pl is wrong.
regards,
dan carpenter
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 30 lines · Nicholas Krause
Quoted 27 lines · Dan Carpenter
Quoted 1 line · Nicholas Krause
Fixes the checkpath.pl error where the opening bracket has a unneeded
space between
Quoted 1 line
it and the function name for a if statement in the
marco,VMX_WAIT_FOR_FIELD32.
Review
Quoted 7 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/octeon-usb/octeon-hcd.cdrivers/staging/octeon-usb/octeon-hcd.c struct octeon_hcd { · line 415
Quoted 9 lines
index 1daeb31..0408a12 100644
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -412,7 +412,7 @@ struct octeon_hcd {type c; \while (1 ) { \ c.u32 =__cvmx_usb_read_csr32 (usb, address); \ - if (c.s.field op (value)) { \ + if (c.s.field op(value)) { \"op" is not a function here. This is macro and top is an operation like
"+" or "*". So checkpatch.pl is wrong.
Quoted 3 lines
Quoted 2 lines
regards,
dan carpenterVery well then, I wasn't sure if we did the same spacing style for marcos.
We do but this is a very unusual case.
regards,
dan carpenter
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 39 lines · Nicholas Krause
Quoted 36 lines · Dan Carpenter
Quoted 3 lines · Nicholas Krause
On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines · Nicholas Krause
Quoted 1 line
Fixes the checkpath.pl error where the opening bracket has a
unneeded
Quoted 28 lines
Quoted 25 lines
space between
Quoted 1 line
it and the function name for a if statement in the
marco,VMX_WAIT_FOR_FIELD32.
Review
Quoted 7 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/octeon-usb/octeon-hcd.cdrivers/staging/octeon-usb/octeon-hcd.c struct octeon_hcd { · line 415
Quoted 9 lines
index 1daeb31..0408a12 100644
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -412,7 +412,7 @@ struct octeon_hcd {type c; \while (1 ) { \ c.u32 =__cvmx_usb_read_csr32 (usb, address); \ - if (c.s.field op (value)) { \ + if (c.s.field op(value)) { \"op" is not a function here. This is macro and top is an operation like
"+" or "*". So checkpatch.pl is wrong.Quoted 2 lines
regards,
dan carpenterVery well then, I wasn't sure if we did the same spacing style for
Quoted 8 lines
Quoted 6 lines
marcos.
We do but this is a very unusual case.
regards,
dan carpenterDan,
Sorry about that my mistake. In addition, have you looked at my second patch to see if that one is correct.
Yes. That one is fine.
regards,
dan carpenter
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · Nicholas Krause
Dan,
Just one more question, is that patch going to be merged or should I resubmit it as a series of one patch?
Don't resubmit. Wait for Greg to mail you. It can take a several weeks because he is busy.
regards,
dan carpetner
Quoted 5 lines · Dan Carpenter
Quoted 2 lines · Nicholas Krause
Just one more question, is that patch going to be merged or should I resubmit it as a series of one patch?
Don't resubmit. Wait for Greg to mail you. It can take a several weeks because he is busy.
What Dan said is certainly true, but if after 4 or more weeks with no reply, I think it's fine to resubmit or send a polite "ping" requesting status.
There really no other option as no other feedback mechanism exists and things can and do get lost in high-volume process.
Hi,
Quoted 50 lines · Nicholas Krause
Quoted 49 lines · Dan Carpenter
Quoted 1 line · Nicholas Krause
On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
Quoted 17 lines · <[email protected]> wrote:
Quoted 17 lines · Nicholas Krause
Quoted 1 line
On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines · Nicholas Krause
Quoted 1 line
Fixes the checkpath.pl error where the opening bracket has a
unneeded
Quoted 11 lines
Quoted 11 lines
space between
Quoted 1 line
it and the function name for a if statement in the
marco,VMX_WAIT_FOR_FIELD32.
Review
Quoted 7 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/octeon-usb/octeon-hcd.cQuoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
drivers/staging/octeon-usb/octeon-hcd.c struct octeon_hcd { · line 415
Quoted 9 lines
index 1daeb31..0408a12 100644
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -412,7 +412,7 @@ struct octeon_hcd {type c; \while (1 ) { \ c.u32 =__cvmx_usb_read_csr32 (usb, address); \ - if (c.s.field op (value)) { \ + if (c.s.field op(value)) { \"op" is not a function here. This is macro and top is an
operation
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
like
"+" or "*". So checkpatch.pl is wrong.regards,
dan carpenterVery well then, I wasn't sure if we did the same spacing style
for
Quoted 8 lines
Quoted 6 lines
marcos.
We do but this is a very unusual case.
regards,
dan carpenterDan,
Sorry about that my mistake. In addition, have you looked at mysecond patch to see if that one is correct.
Quoted 7 lines
Quoted 4 lines
Yes. That one is fine.
regards,
dan carpenterDan,
Just one more question, is that patch going to be merged or should I resubmit it as a series of one patch?
Someone else already sent the same patch that got applied:
A.