Skip to contentSkip to conversation

checkkconfigsymbols.py: fix sorted output

PATCH New Valentin Rothberg 1 participant 1 message Mar 23, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkkconfigsymbols.py: fix sorted output

Commit b1a3f243485f ("checkkconfigsymbols.py: make it Git aware") mistakenly removed to print undefined Kconfig symbols in alphabetical order. Furthermore, the script does not print anything anymore when the entire tree is checked (i.e., when no commit is specified).

This patch restores the sorted output and adds the missing print for the default case. Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.

---
This patch is written against the char-misc-next branch in Greg's char-misc git tree; the mentioned commit is not yet in linux-next.

The char-misc tree can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git

---
 scripts/checkkconfigsymbols.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
scripts/checkkconfigsymbols.py +7 -5
index ce9ca60808b8..74086a583d8d 100755
@@ -112,14 +112,15 @@ def main():
         undefined_b = check_symbols()
 
         # report cases that are present for the commit but not before
-        for feature in undefined_b:
+        for feature in sorted(undefined_b):
             # feature has not been undefined before
             if not feature in undefined_a:
-                files = undefined_b.get(feature)
+                files = sorted(undefined_b.get(feature))
                 print "%s\t%s" % (feature, ", ".join(files))
             # check if there are new files that reference the undefined feature
             else:
-                files = undefined_b.get(feature) - undefined_a.get(feature)
+                files = sorted(undefined_b.get(feature) -
+                               undefined_a.get(feature))
                 if files:
                     print "%s\t%s" % (feature, ", ".join(files))
 
@@ -129,8 +130,9 @@ def main():
     # default to check the entire tree
     else:
         undefined = check_symbols()
-        for feature in undefined:
-            files = undefined.get(feature)
+        for feature in sorted(undefined):
+            files = sorted(undefined.get(feature))
+            print "%s\t%s" % (feature, ", ".join(files))
 
 
 def execute(cmd):
Signature · 1 line
2.1.0