Skip to contentSkip to conversation

hfsplus: fix expand when not enough available space

PATCH Viacheslav Dubeyko 1 participant 1 message Mar 23, 2015 1 message not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 19 lines · Hin-Tak Leung

------------------------------

Quoted 6 lines

To be honest, I am not fully understand what is the case of the fix. As a result, I can understand correctness of the fix. Could you describe the issue and the fix in more details? Could you provide more clear description of the use-case of such issue? Anyway, this fix requires in more clear and detailed description.

I think I understand the description, though I have not checked the code itself in detail (and the fat driver origin). The use of 'truncate' to illustrate the problem is a bit unfortunate, as the issue is not about making a file smaller, but larger, e.g. seek'ing beyond the end of a file
to expand it. It should fail if one seeks too far
and try to create a very large file, but it currently does not fail (or so it says), but results in an inconsistent file system.

Quoted 2 lines

Hope this helps.

Description of the fix needs in correction because current description doesn't provide enough details for clear understanding of the issue and the fix. Currently, it's hard to realize the fix, from my point of view.

Thanks,
Vyacheslav Dubeyko.