Skip to contentSkip to conversation

Dma: at_hdmac_regs fixed a space coding style issue

PATCH In review Andrei Maresu 2 participants 2 messages Mar 23, 2015 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Dma: at_hdmac_regs fixed a space coding style issue

The following chaeckpatch error was fixed:
ERROR: space prohibited after that open parenthesis '('

---
 drivers/dma/at_hdmac_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/at_hdmac_regs.h +1 -1
index 2727ca5..76611a3 100644
@@ -53,7 +53,7 @@
 
 #define	AT_DMA_CHER	0x28	/* Channel Handler Enable Register */
 #define		AT_DMA_ENA(x)	(0x1 << (x))
-#define		AT_DMA_SUSP(x)	(0x1 << ( 8 + (x)))
+#define		AT_DMA_SUSP(x)	(0x1 << (8 + (x)))
 #define		AT_DMA_KEEP(x)	(0x1 << (24 + (x)))
 
 #define	AT_DMA_CHDR	0x2C	/* Channel Handler Disable Register */

--
1.9.1

#1 lore raw
Quoted 2 lines · Andrei Maresu

The following chaeckpatch error was fixed:
ERROR: space prohibited after that open parenthesis '('

[]

drivers/dma/at_hdmac_regs.h

Quoted 1 line
drivers/dma/at_hdmac_regs.h +0 -0

[]

drivers/dma/at_hdmac_regs.h line 57

Quoted 7 lines
drivers/dma/at_hdmac_regs.h +1 -1
@@ -53,7 +53,7 @@
 
 #define	AT_DMA_CHER	0x28	/* Channel Handler Enable Register */
 #define		AT_DMA_ENA(x)	(0x1 << (x))
-#define		AT_DMA_SUSP(x)	(0x1 << ( 8 + (x)))
+#define		AT_DMA_SUSP(x)	(0x1 << (8 + (x)))
 #define		AT_DMA_KEEP(x)	(0x1 << (24 + (x)))

Meh.

I think this isn't much of an improvement.
This was likely done to align these AT_ defines.

Another option might be to use the BIT macro.

#define AT_DMA_SUSP(x) BIT((x) + 8)
#define AT_DMA_KEEP(x) BIT((x) + 24)