Skip to contentSkip to conversation

pci: iproc: fix PCIE_IPROC in Kconfig

PATCH In review Ray Jui 2 participants 3 messages Mar 24, 2015 – Mar 25, 2015 PCI

lore
Share & tools
lore

Ray Jui

author
#0 lore raw

PATCH 1/1 pci: iproc: fix PCIE_IPROC in Kconfig

Make PCIE_IPROC depending on both OF and ARM and default to be disabled, so it cannot be accidentally enabled by other platforms

PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly it's enabled by PCIE_IPROC_PLTFM driver

---
 drivers/pci/host/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/pci/host/Kconfig +2 -0
index feccd0d..963b507 100644
@@ -108,6 +108,8 @@ config PCI_VERSATILE
 
 config PCIE_IPROC
 	tristate "Broadcom iProc PCIe controller"
+	depends on OF && ARM
+	default n
 	help
 	  This enables the iProc PCIe core controller support for Broadcom's
 	  iProc family of SoCs. An appropriate bus interface driver also needs
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 16 lines · Ray Jui

Make PCIE_IPROC depending on both OF and ARM and default to be disabled, so it cannot be accidentally enabled by other platforms

PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly it's enabled by PCIE_IPROC_PLTFM driver

---
 drivers/pci/host/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/pci/host/Kconfig +0 -0
index feccd0d..963b507 100644

drivers/pci/host/Kconfig config PCI_VERSATILE · line 115

Quoted 8 lines
drivers/pci/host/Kconfig +2 -0
@@ -108,6 +108,8 @@ config PCI_VERSATILE
 
 config PCIE_IPROC
        tristate "Broadcom iProc PCIe controller"
+       depends on OF && ARM
+       default n
        help
          This enables the iProc PCIe core controller support for Broadcom's
          iProc family of SoCs. An appropriate bus interface driver also needs

What pattern are you following? There must be other drivers with similar front-end bus driver schemes, and I'd rather copy their Kconfig descriptions than invent something new.

With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't seem like there's anything to gain by abbreviating it.

Bjorn

author
#2 lore raw

Hi Bjorn,

Quoted 18 lines · Bjorn Helgaas
Quoted 17 lines · Ray Jui

Make PCIE_IPROC depending on both OF and ARM and default to be disabled, so it cannot be accidentally enabled by other platforms

PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly it's enabled by PCIE_IPROC_PLTFM driver

 drivers/pci/host/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/pci/host/Kconfig +0 -0
index feccd0d..963b507 100644
@@ -108,6 +108,8 @@ config PCI_VERSATILE
 
Quoted 11 lines

drivers/pci/host/Kconfig config PCI_VERSATILE · line 115

Quoted 7 lines
drivers/pci/host/Kconfig +2 -0
 config PCIE_IPROC
        tristate "Broadcom iProc PCIe controller"
+       depends on OF && ARM
+       default n
        help
          This enables the iProc PCIe core controller support for Broadcom's
          iProc family of SoCs. An appropriate bus interface driver also needs

What pattern are you following? There must be other drivers with similar front-end bus driver schemes, and I'd rather copy their Kconfig descriptions than invent something new.

I'm not aware of other drivers using a similar model to support different front-end bus interfaces. Note this is requested by Arnd Bergmann to support a normal platform bus interface and a BCMA bus interface, which is quite unique.

PCIE_DW may be close in a way in terms of how the core code are retained in PCIE_DW driver with PCI_EXYNOS, PCI_IMX6, and etc. to take care of SoC specific things.

Note PCIE_DW currently has no Kconfig descriptions.

Quoted 3 lines

With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"? Doesn't seem like there's anything to gain by abbreviating it.

Sure. I'll submit a new patch series, which will contain this patch, and another patch on top, to change from CONFIG_PCIE_IPROC_PLTFM to CONFIG_PCIE_IPROC_PLATFORM.

Quoted 3 lines

Bjorn

Thanks,

Ray