Skip to contentSkip to conversation

hv_vmbus: Add gradually increased delay for retries in vmbus_post_msg()

PATCH In review Haiyang Zhang 2 participants 2 messages Mar 25, 2015 – Mar 27, 2015 Hyper-V/Azure core and drivers

lore
Share & tools
lore

Haiyang Zhang

author maintainer
#0 lore raw

PATCH 1/1 hv_vmbus: Add gradually increased delay for retries in vmbus_post_msg()

Most of the retries can be done within a millisecond successfully, so we sleep 1ms before the first retry, then gradually increase the retry interval to 2^n with max value of 2048ms. Doing so, we will have shorter overall delay time, because most of the cases succeed within 1-2 attempts.

---
 drivers/hv/connection.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
drivers/hv/connection.c +5 -2
index 583d7d4..b27220a 100644
@@ -422,6 +422,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 	union hv_connection_id conn_id;
 	int ret = 0;
 	int retries = 0;
+	u32 msec = 1;
 
 	conn_id.asu32 = 0;
 	conn_id.u.id = VMBUS_MESSAGE_CONNECTION_ID;
@@ -431,7 +432,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 	 * insufficient resources. Retry the operation a couple of
 	 * times before giving up.
 	 */
-	while (retries < 10) {
+	while (retries < 20) {
 		ret = hv_post_message(conn_id, 1, buffer, buflen);
 
 		switch (ret) {
@@ -454,7 +455,9 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 		}
 
 		retries++;
-		msleep(1000);
+		msleep(msec);
+		if (msec < 2048)
+			msec *= 2;
 	}
 	return ret;
 }
Signature · 1 line
1.7.4.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 43 lines

-----Original Message-----
From: devel [mailto:[email protected]] On Behalf Of Haiyang Zhang
Sent: Thursday, March 26, 2015 6:59
To: KY Srinivasan
Cc: [email protected]; Haiyang Zhang; driverdev- [email protected]; [email protected]; [email protected]
Subject: [PATCH] hv_vmbus: Add gradually increased delay for retries in vmbus_post_msg()

Most of the retries can be done within a millisecond successfully, so we sleep 1ms before the first retry, then gradually increase the retry interval to 2^n with max value of 2048ms. Doing so, we will have shorter overall delay time, because most of the cases succeed within 1-2 attempts.

---
 drivers/hv/connection.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
drivers/hv/connection.c +2 -1
index 583d7d4..b27220a 100644
@@ -422,6 +422,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 	union hv_connection_id conn_id;
 	int ret = 0;
 	int retries = 0;
+	u32 msec = 1;
 
 	conn_id.asu32 = 0;
 	conn_id.u.id = VMBUS_MESSAGE_CONNECTION_ID;
@@ -431,7 +432,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 	 * insufficient resources. Retry the operation a couple of
 	 * times before giving up.
 	 */
-	while (retries < 10) {
+	while (retries < 20) {
 		ret = hv_post_message(conn_id, 1, buffer, buflen);
 
 		switch (ret) {

drivers/hv/connection.c int vmbus_post_msg(void *buffer, size_t buflen) · line 463

Quoted 10 lines
drivers/hv/connection.c +3 -1
@@ -454,7 +455,9 @@ int vmbus_post_msg(void *buffer, size_t buflen)
 		}
 
 		retries++;
-		msleep(1000);
+		msleep(msec);
+		if (msec < 2048)
+			msec *= 2;
 	}
 	return ret;
 }

The patch is good to me.