dpkg-native: Avoid 'file changed' errors from tar

See the patch header for details. Hardlink count duing do_package_write_deb can change causing dpkg-deb failures. We don't care about this error case so avoid it by checking the tar exit code.

[YOCTO #7529]

Signed-off-by Richard Purdie <[email protected]>

Quoted 6 lines · Richard Purdie

See the patch header for details. Hardlink count duing do_package_write_deb can change causing dpkg-deb failures. We don't care about this error case so avoid it by checking the tar exit code.

[YOCTO #7529]

Quoted 1 line

Signed-off-by Richard Purdie <[email protected]>

Please don't ask someone to see the patch header for information. This should be in the commit log and not necessarily read the diff to find this information.

Please send a v2 adding this information in the commit log.

Quoted 14 lines · Otavio Salvador

Quoted 7 lines · Richard Purdie

See the patch header for details. Hardlink count duing do_package_write_deb can change causing dpkg-deb failures. We don't care about this error case so avoid it by checking the tar exit code.

[YOCTO #7529]

Signed-off-by Richard Purdie <[email protected]>

Please don't ask someone to see the patch header for information. This should be in the commit log and not necessarily read the diff to find this information.

Quoted 1 line

Please send a v2 adding this information in the commit log.

Just referring someone to the patch header would be incorrect and I agree a summary of the problem is needed. The commit message in question does have this. I don't see the point of cut and pasting all the details from the header into the commit message. The correct place for the details in a situation like this is the patch header so that someone has full details of the patch without having to look at the repo history.

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +7 -0

+When running do_package_write_deb, we have trees of symlinked files
+such as the dbg source files in ${PN}-dbg. If something makes another
+copy of one of those files (or deletes one), the number of links a file
+has changes and tar can notice this, e.g.:
+
+| DEBUG: Executing python function do_package_deb
+| dpkg-deb: building package `sed-ptest' in

`/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'. +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
+| dpkg-deb: error: subprocess tar -cf returned error exit status 1

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +5 -0

+
+Tar returns an error of 1 when files 'change' and other errors codes
+in other error cases. We tweak dpkg-deb here so that it ignores an exit
+code of 1 from tar. The files don't really change (and we have locking in
+place to avoid that kind of issue).

This is exactly what I would expect for the long commit log. Sorry but I strongly disagrese with you as the commit log in the patch does connect with the short log so I still believe the commit log could be improved.

Quoted 16 lines · Otavio Salvador

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +7 -0

+When running do_package_write_deb, we have trees of symlinked files
+such as the dbg source files in ${PN}-dbg. If something makes another
+copy of one of those files (or deletes one), the number of links a file
+has changes and tar can notice this, e.g.:
+
+| DEBUG: Executing python function do_package_deb
+| dpkg-deb: building package `sed-ptest' in

`/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'. +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
+| dpkg-deb: error: subprocess tar -cf returned error exit status 1

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +5 -0

+
+Tar returns an error of 1 when files 'change' and other errors codes
+in other error cases. We tweak dpkg-deb here so that it ignores an exit
+code of 1 from tar. The files don't really change (and we have locking in
+place to avoid that kind of issue).

Quoted 4 lines

This is exactly what I would expect for the long commit log. Sorry but I strongly disagrese with you as the commit log in the patch does connect with the short log so I still believe the commit log could be improved.

Well, I strong disagree with that, I don't believe it makes sense to cut and paste the same information into both places, sorry.

Quoted 17 lines · Richard Purdie

Quoted 16 lines · Otavio Salvador

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +7 -0

+When running do_package_write_deb, we have trees of symlinked files
+such as the dbg source files in ${PN}-dbg. If something makes another
+copy of one of those files (or deletes one), the number of links a file
+has changes and tar can notice this, e.g.:
+
+| DEBUG: Executing python function do_package_deb
+| dpkg-deb: building package `sed-ptest' in

`/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'. +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
+| dpkg-deb: error: subprocess tar -cf returned error exit status 1

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +5 -0

+
+Tar returns an error of 1 when files 'change' and other errors codes
+in other error cases. We tweak dpkg-deb here so that it ignores an exit
+code of 1 from tar. The files don't really change (and we have locking in
+place to avoid that kind of issue).

Quoted 7 lines

Quoted 4 lines

This is exactly what I would expect for the long commit log. Sorry but I strongly disagrese with you as the commit log in the patch does connect with the short log so I still believe the commit log could be improved.

Well, I strong disagree with that, I don't believe it makes sense to cut and paste the same information into both places, sorry.

I disagree someone should go into a patch header to understand it.

Quoted 27 lines · Otavio Salvador

Quoted 24 lines · Richard Purdie

Quoted 16 lines · Otavio Salvador

(quoted diff) +7 -0

+When running do_package_write_deb, we have trees of symlinked files
+such as the dbg source files in ${PN}-dbg. If something makes another
+copy of one of those files (or deletes one), the number of links a file
+has changes and tar can notice this, e.g.:
+
+| DEBUG: Executing python function do_package_deb
+| dpkg-deb: building package `sed-ptest' in

`/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'. +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
+| dpkg-deb: error: subprocess tar -cf returned error exit status 1

(quoted diff) +5 -0

+
+Tar returns an error of 1 when files 'change' and other errors codes
+in other error cases. We tweak dpkg-deb here so that it ignores an exit
+code of 1 from tar. The files don't really change (and we have locking in
+place to avoid that kind of issue).

Quoted 4 lines

This is exactly what I would expect for the long commit log. Sorry but I strongly disagrese with you as the commit log in the patch does connect with the short log so I still believe the commit log could be improved.

Well, I strong disagree with that, I don't believe it makes sense to cut and paste the same information into both places, sorry.

Quoted 2 lines

I disagree someone should go into a patch header to understand it.

I agree with Otavio here. When generating both short and long changelogs, I always use the commit messages. I don't inspect the contents of the changes to understand what happened. Having to inspect means that I can't automate the process using the git commands.

--Mark

Quoted 2 lines · Richard Purdie

Quoted 1 line · Otavio Salvador

+When running do_package_write_deb, we have trees of symlinked files

Quoted 15 lines

Quoted 15 lines

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +6 -0

+such as the dbg source files in ${PN}-dbg. If something makes another
+copy of one of those files (or deletes one), the number of links a file
+has changes and tar can notice this, e.g.:
+
+| DEBUG: Executing python function do_package_deb
+| dpkg-deb: building package `sed-ptest' in

`/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'. +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
+| dpkg-deb: error: subprocess tar -cf returned error exit status 1

meta/recipes-devtools/dpkg/dpkg/tar-error-code.patch new file +5 -0

+
+Tar returns an error of 1 when files 'change' and other errors codes
+in other error cases. We tweak dpkg-deb here so that it ignores an exit
+code of 1 from tar. The files don't really change (and we have locking in
+place to avoid that kind of issue).

Quoted 7 lines

Quoted 4 lines

This is exactly what I would expect for the long commit log. Sorry but I strongly disagrese with you as the commit log in the patch does connect with the short log so I still believe the commit log could be improved.

Well, I strong disagree with that, I don't believe it makes sense to cut and paste the same information into both places, sorry.

I disagree someone should go into a patch header to understand it.

Quoted 4 lines · Otavio Salvador

Quoted 2 lines · Richard Purdie

Quoted 1 line · Otavio Salvador

+When running do_package_write_deb, we have trees of symlinked files

Richard, did you intend to write "hardlinked" here?

It's my impression that if Richard had omitted the first sentence of his commit message, the message would still have been descriptive enough, and nobody would ever have complained.