Skip to contentSkip to conversation

Revert "usb: host/sl811-hcd: fix sparse warning"

PATCH In review Sudip Mukherjee 2 participants 2 messages Apr 2, 2015 – Apr 3, 2015 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "usb: host/sl811-hcd: fix sparse warning"

This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.

if we are doing allyesconfig on x86_64, build fails with error:
drivers/built-in.o: In function `sl811_cs_probe':
sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'

this commit has declared sl811h_driver as static but it was being accessed from sl811_cs.c.

---
 drivers/usb/host/sl811-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/sl811-hcd.c +1 -1
index 944a417..f1d5c5a 100644
@@ -1801,7 +1801,7 @@ sl811h_resume(struct platform_device *dev)
 
 
 /* this driver is exported so sl811_cs can depend on it */
-static struct platform_driver sl811h_driver = {
+struct platform_driver sl811h_driver = {
 	.probe =	sl811h_probe,
 	.remove =	sl811h_remove,
 
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 6 lines · Sudip Mukherjee

This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>.

if we are doing allyesconfig on x86_64, build fails with error:
drivers/built-in.o: In function `sl811_cs_probe':
sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver'

Quoted 7 lines

this commit has declared sl811h_driver as static but it was being accessed from sl811_cs.c.

---
 drivers/usb/host/sl811-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Someone else sent this patch in a few days before you did, sorry.

greg k-h