Skip to contentSkip to conversation

staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

PATCH Dan Carpenter 2 participants 3 messages Apr 3, 2015 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev) · line 585

Quoted 7 lines
(quoted diff) +1 -1
@@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 	   IEEE_SOFTMAC_TX_QUEUE)) ||
 	   ((!ieee->softmac_data_hard_start_xmit &&
 	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
-		printk(KERN_WARNING "%s: No xmit handler.\n",
+		netdev_info(ieee->dev, "%s: No xmit handler.\n",

This should be netdev_warn(). There are a few other similar places.

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 15 lines · Nicholas Krause
Quoted 12 lines · Dan Carpenter

Review int rtllib_xmit_inter(struct sk_buff *skb, struct

Quoted 2 lines
(quoted diff) +0 -0
@@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct

net_device *dev)

Review int rtllib_xmit_inter(struct sk_buff *skb, struct · line 585

Quoted 5 lines
(quoted diff) +1 -1
 	   IEEE_SOFTMAC_TX_QUEUE)) ||
 	   ((!ieee->softmac_data_hard_start_xmit &&
 	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
-		printk(KERN_WARNING "%s: No xmit handler.\n",
+		netdev_info(ieee->dev, "%s: No xmit handler.\n",

This should be netdev_warn(). There are a few other similar places.

Quoted 3 lines
Quoted 2 lines

regards,
dan carpenter

My bad will send in a v2 fixing this.

Please don't, I'm not going to be taking patches from you any _year_ soon.

sorry,

greg k-h

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 28 lines · Nicholas Krause
Quoted 25 lines · Greg KH
Quoted 3 lines · Nicholas Krause

On April 3, 2015 5:19:55 AM EDT, Dan Carpenter

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines

Review int rtllib_xmit_inter(struct sk_buff *skb,

Quoted 2 lines
(quoted diff) +0 -0
@@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,

struct

Quoted 10 lines
Quoted 10 lines

net_device *dev)

Review int rtllib_xmit_inter(struct sk_buff *skb, · line 585

Quoted 5 lines
(quoted diff) +1 -1
 	   IEEE_SOFTMAC_TX_QUEUE)) ||
 	   ((!ieee->softmac_data_hard_start_xmit &&
 	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
-		printk(KERN_WARNING "%s: No xmit handler.\n",
+		netdev_info(ieee->dev, "%s: No xmit handler.\n",

This should be netdev_warn(). There are a few other similar places.

Quoted 3 lines
Quoted 2 lines

regards,
dan carpenter

My bad will send in a v2 fixing this.

Please don't, I'm not going to be taking patches from you any _year_ soon.

Quoted 6 lines
Quoted 3 lines

sorry,

greg k-h

Very well then I guess you seem to not trust me no matter how hard I try. Therefore I will avoid helping out in any subsystems you are a maintainer of.

You have not tried at all. You submit patches that don't even apply (like this one), are incorrect, or wrong in some other way.

You activly take up the time and energy of people who are contributing to the kernel, that is why you were banned from vger.kernel.org. You also, when offered a way to learn and redeem yourself, ignored it, and did something else.

What would you do with someone like youself if you were in our shoes?

back into my kill-file you go...

greg k-h