Skip to contentSkip to conversation

e100: don't initialize int object to zero

Intel-wired-lan Jεan Sacren 3 participants 3 messages Apr 5, 2015 – Apr 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Jean Sacren <[email protected]>

'err' will be overwritten so no need to initialize it to zero.

---
 drivers/net/ethernet/intel/e100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/e100.c +1 -1
index 05f88394f9a5..75a11ea7a9d6 100644
@@ -874,7 +874,7 @@ static int e100_exec_cb(struct nic *nic, struct sk_buff *skb,
 {
 	struct cb *cb;
 	unsigned long flags;
-	int err = 0;
+	int err;
 
 	spin_lock_irqsave(&nic->cb_lock, flags);
 
#1 lore raw
Quoted 8 lines · J?an Sacren

From: Jean Sacren <[email protected]>

'err' will be overwritten so no need to initialize it to zero.

---
 drivers/net/ethernet/intel/e100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Jean, I have applied your patch to my queue.

Signature · 9 lines
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150407/04dd4c8d/attachment-0001.asc>
Tested-by Aaron Brown
#2 lore raw
Quoted 18 lines

From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jeff Kirsher
Sent: Tuesday, April 07, 2015 3:59 PM
To: J?an Sacren
Cc: intel-wired-lan at lists.osuosl.org
Subject: Re: [Intel-wired-lan] [net-next] e100: don't initialize int object to zero

Quoted 8 lines · J?an Sacren

From: Jean Sacren <[email protected]>

'err' will be overwritten so no need to initialize it to zero.

---
 drivers/net/ethernet/intel/e100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines

Thanks Jean, I have applied your patch to my queue. --
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue