Skip to contentSkip to conversation

Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt , bsw.

PATCH In review liu,lei 2 participants 3 messages Apr 9, 2015

lore
Share & tools
lore

liu,lei

author
#0 lore raw

PATCH 1/1 Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt , bsw.

From: "liu,lei" <[email protected]>

---
 tests/kms_fbc_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_fbc_crc.c +1 -1
index ccdec33..1320bad 100644
@@ -513,7 +513,7 @@ igt_main
 		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
 		fclose(status);
 		buf[sizeof(buf) - 1] = '\0';
-		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
+		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
 			      !strstr(buf, "disabled per module param") &&
 			      !strstr(buf, "disabled per chip default"),
 			      "FBC not supported/enabled\n");
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 1 line · liu,lei

From: "liu,lei" <[email protected]>

In igt we follow the kernel conventions for patch commit messages:
- First line (subject) summarizes the patch in at most 70 chars
- After an empty line comes the extended commit message (you have that in the first line so it ends up in the subject).
- signed-off-by line at the bottom.

Can you please fix that up and resubmit?

Thanks, Daniel

Quoted 25 lines
---
 tests/kms_fbc_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_fbc_crc.c +1 -1
index ccdec33..1320bad 100644
@@ -513,7 +513,7 @@ igt_main
 		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
 		fclose(status);
 		buf[sizeof(buf) - 1] = '\0';
-		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
+		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
 			      !strstr(buf, "disabled per module param") &&
 			      !strstr(buf, "disabled per chip default"),
 			      "FBC not supported/enabled\n");
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw

Re: [PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt...

I resend that patch. Forgive me that I forgot to add you in cc list. Pardon my original disordered commit message. Really appreciate your guidance.

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Thursday, April 09, 2015 8:24 PM
To: Liu, Lei A
Cc: [email protected]; Tian, YeX; Jin, Gordon
Subject: Re: [Intel-gfx] [PATCH] Correct kms_fbc_crc case Debugfs i915_fbc_status shows "FBC unsupported on this chipset" not "unsupported by this chipset" if the platform doesn't support FBC feature. That typo will cause case fail on some platforms such as byt...

Quoted 1 line · liu,lei

From: "liu,lei" <[email protected]>

In igt we follow the kernel conventions for patch commit messages:
- First line (subject) summarizes the patch in at most 70 chars
- After an empty line comes the extended commit message (you have that in the first line so it ends up in the subject).
- signed-off-by line at the bottom.

Can you please fix that up and resubmit?

Thanks, Daniel

Quoted 21 lines
---
 tests/kms_fbc_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_fbc_crc.c index renamed from tests/kms_fbc_crc.c +0 -0

ccdec33..1320bad 100644

tests/kms_fbc_crc.c +1 -2
@@ -513,7 +513,7 @@ igt_main
 		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
 		fclose(status);
 		buf[sizeof(buf) - 1] = '\0';
-		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
+		igt_require_f(!strstr(buf, "unsupported on this chipset") &&
 			      !strstr(buf, "disabled per module param") &&
 			      !strstr(buf, "disabled per chip default"),
 			      "FBC not supported/enabled\n");
--

1.8.3.1

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx