Skip to contentSkip to conversation

x86: queensbay: Avoid using PCH prefix

PATCH New Bin Meng 2 participants 3 messages Apr 13, 2015 – Apr 20, 2015 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 x86: queensbay: Avoid using PCH prefix

The prefix PCH was taken from ivybridge port. However Queensbay platform official document does not mention PCH. It is composed of TunnelCreek processor and Topcliff IOH chipset. For accuracy, avoid using PCH prefix in the macro.

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/queensbay/tnc.c              | 4 ++--
 arch/x86/include/asm/arch-queensbay/tnc.h | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
arch/x86/cpu/queensbay/tnc.c +2 -2
index 30ab725..ac276d5 100644
@@ -16,9 +16,9 @@ static void unprotect_spi_flash(void)
 {
 	u32 bc;
 
-	bc = pci_read_config32(PCH_LPC_DEV, 0xd8);
+	bc = pci_read_config32(TNC_LPC, 0xd8);
 	bc |= 0x1;	/* unprotect the flash */
-	pci_write_config32(PCH_LPC_DEV, 0xd8, bc);
+	pci_write_config32(TNC_LPC, 0xd8, bc);
 }
 
 int arch_cpu_init(void)
arch/x86/include/asm/arch-queensbay/tnc.h +1 -2
index 67c5e05..10ea51d 100644
@@ -9,7 +9,6 @@
 
 #include <pci.h>
 
-/* PCI Configuration Space (D31:F0): LPC */
-#define PCH_LPC_DEV	PCI_BDF(0, 0x1f, 0)
+#define TNC_LPC		PCI_BDF(0, 31, 0)
 
 #endif /* _X86_ARCH_TNC_H_ */
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 x86: queensbay: Avoid using PCH prefix

Quoted 11 lines · Bin Meng

The prefix PCH was taken from ivybridge port. However Queensbay platform official document does not mention PCH. It is composed of TunnelCreek processor and Topcliff IOH chipset. For accuracy, avoid using PCH prefix in the macro.

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/queensbay/tnc.c              | 4 ++--
 arch/x86/include/asm/arch-queensbay/tnc.h | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 x86: queensbay: Avoid using PCH prefix

Quoted 6 lines · Simon Glass
Quoted 5 lines · Bin Meng

The prefix PCH was taken from ivybridge port. However Queensbay platform official document does not mention PCH. It is composed of TunnelCreek processor and Topcliff IOH chipset. For accuracy, avoid using PCH prefix in the macro.

Quoted 8 lines
Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/queensbay/tnc.c              | 4 ++--
 arch/x86/include/asm/arch-queensbay/tnc.h | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-x86, thanks!