netfilter: nf_tables: fix wrong length for jump/goto verdicts
Subsystems (2)
Florian Westphal
maintainerPATCH 1/1 netfilter: nf_tables: fix wrong length for jump/goto verdicts
NFT_JUMP/GOTO erronously sets length to sizeof(void *).
We then allocate insufficient memory when such element is added to a vmap.
Suggested-by Patrick McHardy <[email protected]>
Signed-off-by Florian Westphal <[email protected]>
--- net/netfilter/nf_tables_api.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/netfilter/nf_tables_api.c +1 -2
@@ -4340,7 +4340,6 @@ static int nft_verdict_init(const struct nft_ctx *ctx, struct nft_data *data,case NFT_CONTINUE :case NFT_BREAK :case NFT_RETURN : - desc->len =sizeof (data->verdict);break ;case NFT_JUMP :case NFT_GOTO :
@@ -4355,10 +4354,10 @@ static int nft_verdict_init(const struct nft_ctx *ctx, struct nft_data *data, chain->use++; data->verdict.chain = chain; - desc->len =sizeof (data);break ; } + desc->len =sizeof (data->verdict); desc->type =NFT_DATA_VERDICT ;return 0 ; }
Signature · 1 line
2.0.5
Quoted 3 lines · Florian Westphal
NFT_JUMP/GOTO erronously sets length to
sizeof(void *).We then allocate insufficient memory when such element is added to a vmap.
Applied, thanks Florian.