drm/i915: Fix view type in warning message
Subsystems (2)
PATCH 1/1 drm/i915: Fix view type in warning message
From: Tvrtko Ursulin <[email protected]>
One month passed between posting a patch and it getting merged, and unfortunately even though it still applies, it needs fixing to account for changes in function parameters since:
commit d385612e15b8b6eb3db328d83f1872ef8a381788
Author: Tvrtko Ursulin <[email protected]>
Date: Tue Mar 17 14:45:29 2015 +0000
drm/i915: Log view type when printing warnings
--- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +1 -1
@@ -5181,7 +5181,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o, i915_ggtt_view_equal(&vma->ggtt_view, view))return vma->node.start; -WARN (1 ,"global vma for this object not found. (view=%u)\n" , view); +WARN (1 ,"global vma for this object not found. (view=%u)\n" , view->type);return -1 ; }
Signature · 6 lines
2.3.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
One month passed between posting a patch and it getting merged, and unfortunately even though it still applies, it needs fixing to account for changes in function parameters since:
Quoted 7 lines
commit
d385612e15b8b6eb3db328d83f1872ef8a381788
Author: Tvrtko Ursulin <[email protected]>
Date: Tue Mar 17 14:45:29 2015 +0000drm/i915: Log view type when printing warnings
Signed-off-by Tvrtko Ursulin <[email protected]>
This patch makes the debug message useful. (Should be applied on top of the previous patch).
Regards, Joonas
Quoted 10 lines
Cc Joonas Lahtinen <[email protected]>--- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem.c +0
-0
drivers/gpu/drm/i915/i915_gem.c i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o, · line 5187
Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1
-1@@ -5181,7 +5181,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o, i915_ggtt_view_equal(&vma->ggtt_view, view))return vma->node.start; -WARN (1 ,"global vma for this object not found. (view=%u)\n" , view); +WARN (1 ,"global vma for this object not found. (view=%u)\n" , view->type);return -1 ; }
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 11 lines · Joonas Lahtinen
Quoted 10 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
One month passed between posting a patch and it getting merged, and unfortunately even though it still applies, it needs fixing to account for changes in function parameters since:
commit d385612e15b8b6eb3db328d83f1872ef8a381788 Author: Tvrtko Ursulin <[email protected]> Date: Tue Mar 17 14:45:29 2015 +0000
Quoted 5 lines
Quoted 3 lines
drm/i915: Log view type when printing warnings
Signed-off-by Tvrtko Ursulin <[email protected]>Reviewed-by Joonas Lahtinen <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx