Skip to contentSkip to conversation

hpfs: Remove unessary cast

PATCH New Firo Yang 3 participants 4 messages Apr 23, 2015 – May 2, 2015 Hpfs filesystem

lore
Share & tools
lore

Firo Yang

author
#0 lore raw

PATCH 1/1 hpfs: Remove unessary cast

Avoid a pointless kmem_cache_alloc() return value cast in fs/hpfs/super.c::hpfs_alloc_inode()

---
 fs/hpfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/hpfs/super.c +1 -1
index 7cd00d3..ccace08 100644
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
 static struct inode *hpfs_alloc_inode(struct super_block *sb)
 {
 	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
 	ei->vfs_inode.i_version = 1;
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 hpfs: Remove unessary cast

Avoid a pointless kmem_cache_alloc() return value cast in fs/hpfs/super.c::hpfs_alloc_inode()

---
fs/hpfs/super.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line
fs/hpfs/super.c +0 -0
index 7cd00d3..ccace08 100644
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;

static struct inode *hpfs_alloc_inode(struct super_block *sb)

{
	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
	if (!ei)
		return NULL;
	ei->vfs_inode.i_version = 1;
#2 lore raw

Mikulas, when forwarding patches from others, you also need to add that

"From: Firo Yang <[email protected]>"

at the top (and it can be nice if you also add the date-line). Otherwise authorship gets lost.

Sign-off lines _normally_ show the whole authorship chain too, but no, it's not enough to just have the sign-off line there.

Linus

Quoted 26 lines · Mikulas Patocka

Avoid a pointless kmem_cache_alloc() return value cast in fs/hpfs/super.c::hpfs_alloc_inode()

---
fs/hpfs/super.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines
fs/hpfs/super.c +1 -1
index 7cd00d3..ccace08 100644
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
 static struct inode *hpfs_alloc_inode(struct super_block *sb)
 {
        struct hpfs_inode_info *ei;
-       ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep,
 GFP_NOFS);
+       ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
        if (!ei)
                return NULL;
        ei->vfs_inode.i_version = 1;
#3 lore raw
Quoted 11 lines · Linus Torvalds

Mikulas, when forwarding patches from others, you also need to add that

"From: Firo Yang <[email protected]>"

at the top (and it can be nice if you also add the date-line). Otherwise authorship gets lost.

Sign-off lines _normally_ show the whole authorship chain too, but no, it's not enough to just have the sign-off line there.

Linus

OK, so I sent it the second time, I hope that your script processes it better.

Mikulas