Skip to contentSkip to conversation

Fix: multiple definition error with gcc 5.1

PATCH Zifei Tong 2 participants 2 messages Apr 27, 2015 – May 22, 2015 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CAJ7wx-Eze7hKh3ZTcxDTREois10BjoQ_118W2W8k4vUQd0bOSg@mail.gmail.com

#3 lore raw

Hi Zifei,

It seems I had missed the patch you had sent with this e-mail. I did end up having the same issue today as I upgraded to gcc 5.1.

My fix is a combination of what was reported on the open embedded mailing list (marking the mi and config declarations as extern) and removing what was left of the function:entry feature.

commit 96ffaa0c61089296dd5c9dd07810f32f97931fc8

Author: Jérémie Galarneau <[email protected]>
Date:   Fri May 22 12:55:57 2015 -0400

Clean-up: Remove ifdef-ed out function:entry feature

commit 4965f956f3ef47388fb4a1b2f8f504abfe31afe7

Author: Jérémie Galarneau <[email protected]>
Date:   Fri May 22 12:53:30 2015 -0400

Fix: Mark MI and Config string declarations as extern

This fixes a build issue with GCC 5.1 which would complain about these symbols being defined multiple times.

Thanks a lot and sorry for the delay!
Jérémie

Quoted 7 lines · Zifei Tong

I created a minimal reproducer [1] for the UB if you are interested.

[1]: https://gist.github.com/5kg/7304cf74bc0fe13a9f70

Thanks,
Zifei Tong

Signature · 3 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev