drm/i915: Clear vma->bound on unbinding
Subsystems (2)
PATCH 1/1 drm/i915: Clear vma->bound on unbinding
Unbinding doesn't always lead to unconditional destruction of vma. This destruction avoidance happens if vma is part of execbuffer relocation list or if vma is being considered for eviction in i915_gem_evict_something().
For those other users, mark the vma unbound so that the correct state of this vma is preserved.
--- drivers/gpu/drm/i915/i915_gem.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -3069,6 +3069,7 @@ int i915_vma_unbind(struct i915_vma *vma)trace_i915_vma_unbind (vma); vma->vm->unbind_vma (vma); + vma->bound =0 ;list_del_init (&vma->mm_list);if (i915_is_ggtt (vma->vm)) {
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6297 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK -1 302/302 301/302
SNB 316/316 316/316 IVB 264/264 264/264
BYT -3 227/227 224/227
BDW 318/318 318/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*ILK igt@gem_mmap_offset_exhaustion PASS(2) CRASH(1)PASS(1) *BYT igt@gem_dummy_reloc_loop@render FAIL(1)PASS(16) TIMEOUT(1)PASS(1) *BYT igt@gem_exec_parse@batch-without-end FAIL(1)PASS(2) DMESG_WARN(1)PASS(1)
(dmesg patch applied)drm:check_crtc_state[i915]]*ERROR*mismatch_in_has_infoframe(expected#,found#)@mismatch in has_infoframe .* found WARNING:at_drivers/gpu/drm/i915/intel_display.c:#check_crtc_state[i915]()@WARNING:.* at .* check_crtc_state+0x
BYT igt@gem_pipe_control_store_loop@fresh-buffer FAIL(1)TIMEOUT(8)PASS(9) TIMEOUT(2)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 5 lines · Mika Kuoppala
Unbinding doesn't always lead to unconditional destruction of vma. This destruction avoidance happens if vma is part of execbuffer relocation list or if vma is being considered for eviction in
i915_gem_evict_something().
Quoted 7 lines
For those other users, mark the vma unbound so that the correct state of this vma is preserved.
Reported-by Chris Wilson <[email protected]>Cc Chris Wilson <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
I guess I still need this one?
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx