Skip to contentSkip to conversation

Patch "md/raid0: fix bug with chunksize not a power of 2." has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

md/raid0: fix bug with chunksize not a power of 2.

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
md-raid0-fix-bug-with-chunksize-not-a-power-of-2.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 47d68979cc968535cb87f3e5f2e6a3533ea48fbd Mon Sep 17 00:00:00 2001

From: NeilBrown <[email protected]>
Date: Fri, 10 Apr 2015 13:19:04 +1000
Subject: md/raid0: fix bug with chunksize not a power of 2.

From: NeilBrown <[email protected]>

commit 47d68979cc968535cb87f3e5f2e6a3533ea48fbd upstream.

Since commit 20d0189b1012a37d2533a87fb451f7852f2418d1 in v3.14-rc1 RAID0 has performed incorrect calculations when the chunksize is not a power of 2.

This happens because "sector_div()" modifies its first argument, but this wasn't taken into account in the patch.

So restore that first arg before re-using the variable.

Fixes 20d0189b1012a37d2533a87fb451f7852f2418d1
---
 drivers/md/raid0.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/md/raid0.c +2 -1
@@ -313,7 +313,7 @@ static struct strip_zone *find_zone(stru
 
 /*
  * remaps the bio to the target device. we separate two flows.
- * power 2 flow and a general flow for the sake of perfromance
+ * power 2 flow and a general flow for the sake of performance
 */
 static struct md_rdev *map_sector(struct mddev *mddev, struct strip_zone *zone,
 				sector_t sector, sector_t *sector_offset)
@@ -524,6 +524,7 @@ static void raid0_make_request(struct md
 			split = bio;
 		}
 
+		sector = bio->bi_iter.bi_sector;
 		zone = find_zone(mddev->private, &sector);
 		tmp_dev = map_sector(mddev, zone, sector, &sector);
 		split->bi_bdev = tmp_dev->bdev;

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/md-fix-md-io-stats-accounting-broken.patch queue-4.0/md-raid0-fix-bug-with-chunksize-not-a-power-of-2.patch