Skip to contentSkip to conversation

Patch "ACPICA: Tables: Don't release ACPI_MTX_TABLES in acpi_tb_install_standard_table()." has been added to the 3.19-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ACPICA: Tables: Don't release ACPI_MTX_TABLES in acpi_tb_install_standard_table().

to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpica-tables-don-t-release-acpi_mtx_tables-in-acpi_tb_install_standard_table.patch
and it can be found in the queue-3.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 77ddc2fe08329e375505bc36a3df3233fe57317b Mon Sep 17 00:00:00 2001

From: Octavian Purdila <[email protected]>
Date: Mon, 13 Apr 2015 11:49:05 +0800
Subject: ACPICA: Tables: Don't release ACPI_MTX_TABLES in acpi_tb_install_standard_table().

From: Octavian Purdila <[email protected]>

commit 77ddc2fe08329e375505bc36a3df3233fe57317b upstream.

ACPICA commit c70434d4da13e65b6163c79a5aa16b40193631c7

ACPI_MTX_TABLES is acquired and released by the callers of acpi_tb_install_standard_table() so releasing it in the function itself is causing the following error in Linux kernel if the table is reloaded:

ACPI Error: Mutex [0x2] is not acquired, cannot release (20141107/utmutex-321)

Call Trace:
  [<ffffffff81b0bd48>] dump_stack+0x4f/0x7b
  [<ffffffff81546bf5>] acpi_ut_release_mutex+0x47/0x67
  [<ffffffff81544357>] acpi_load_table+0x73/0xcb
---
 drivers/acpi/acpica/tbinstal.c |    1 -
 1 file changed, 1 deletion(-)
drivers/acpi/acpica/tbinstal.c +0 -1
@@ -346,7 +346,6 @@ acpi_tb_install_standard_table(acpi_phys
 				 */
 				acpi_tb_uninstall_table(&new_table_desc);
 				*table_index = i;
-				(void)acpi_ut_release_mutex(ACPI_MTX_TABLES);
 				return_ACPI_STATUS(AE_OK);
 			}
 		}

Patches currently in stable-queue which might be from [email protected] are

queue-3.19/acpica-tables-don-t-release-acpi_mtx_tables-in-acpi_tb_install_standard_table.patch