Skip to contentSkip to conversation

FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after requesting offers" failed to apply to 4.0-stable tree

PATCH [email protected] 2 participants 2 messages May 2, 2015 – May 3, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.0-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 73cffdb65e679b98893f484063462c045adcf212 Mon Sep 17 00:00:00 2001

From: "K. Y. Srinivasan" <[email protected]>
Date: Thu, 19 Mar 2015 08:11:34 -0700
Subject: [PATCH] Drivers: hv: vmbus: Don't wait after requesting offers

Don't wait after sending request for offers to the host. This wait is unnecessary and simply adds 5 seconds to the boot time.

drivers/hv/channel_mgmt.c +0 -11
index 25dbbaf42266..bb39705a89d9 100644
@@ -884,7 +884,6 @@ int vmbus_request_offers(void)
 	struct vmbus_channel_message_header *msg;
 	struct vmbus_channel_msginfo *msginfo;
 	int ret;
-	unsigned long t;
 
 	msginfo = kmalloc(sizeof(*msginfo) +
 			  sizeof(struct vmbus_channel_message_header),
@@ -892,8 +891,6 @@ int vmbus_request_offers(void)
 	if (!msginfo)
 		return -ENOMEM;
 
-	init_completion(&msginfo->waitevent);
-
 	msg = (struct vmbus_channel_message_header *)msginfo->msg;
 
 	msg->msgtype = CHANNELMSG_REQUESTOFFERS;
@@ -907,14 +904,6 @@ int vmbus_request_offers(void)
 		goto cleanup;
 	}
 
-	t = wait_for_completion_timeout(&msginfo->waitevent, 5*HZ);
-	if (t == 0) {
-		ret = -ETIMEDOUT;
-		goto cleanup;
-	}
-
-
-
 cleanup:
 	kfree(msginfo);
 
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Saturday, May 2, 2015 10:06 AM
To: KY Srinivasan; [email protected]; [email protected]
Cc: [email protected]
Subject: FAILED: patch "[PATCH] Drivers: hv: vmbus: Don't wait after requesting offers" failed to apply to 4.0-stable tree

Quoted 4 lines

The patch below does not apply to the 4.0-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Greg,

I have resent the patch with the fix to apply against the 4.0 tree.

Thanks,

K. Y

Quoted 55 lines

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 73cffdb65e679b98893f484063462c045adcf212 Mon Sep 17 00:00:00 2001
From: "K. Y. Srinivasan" <[email protected]>
Date: Thu, 19 Mar 2015 08:11:34 -0700
Subject: [PATCH] Drivers: hv: vmbus: Don't wait after requesting offers

Don't wait after sending request for offers to the host. This wait is unnecessary and simply adds 5 seconds to the boot time.

drivers/hv/channel_mgmt.c +0 -11
index 25dbbaf42266..bb39705a89d9 100644
@@ -884,7 +884,6 @@ int vmbus_request_offers(void)
 	struct vmbus_channel_message_header *msg;
 	struct vmbus_channel_msginfo *msginfo;
 	int ret;
-	unsigned long t;
 
 	msginfo = kmalloc(sizeof(*msginfo) +
 			  sizeof(struct vmbus_channel_message_header),
@@ -892,8 +891,6 @@ int vmbus_request_offers(void)
 	if (!msginfo)
 		return -ENOMEM;
 
-	init_completion(&msginfo->waitevent);
-
 	msg = (struct vmbus_channel_message_header *)msginfo->msg;
 
 	msg->msgtype = CHANNELMSG_REQUESTOFFERS;
@@ -907,14 +904,6 @@ int vmbus_request_offers(void)
 		goto cleanup;
 	}
 
-	t = wait_for_completion_timeout(&msginfo->waitevent, 5*HZ);
-	if (t == 0) {
-		ret = -ETIMEDOUT;
-		goto cleanup;
-	}
-
-
-
 cleanup:
 	kfree(msginfo);