mfd: lpc_ich: Assign subdevice ids automatically
Subsystems (2)
PATCH 1/1 mfd: lpc_ich: Assign subdevice ids automatically
Using -1 as platform device id means that the platform driver core will not assign any id to the device (the device name will not have id at all). This results problems on systems that have multiple PCHs (Platform Controller HUBs) because all of them also include their own copy of LPC device.
All the subsequent device creations will fail because there already exists platform device with the same name.
Fix this by passing -2 as a platform device id. This makes the platform device core to allocate new ids automatically.
--- drivers/mfd/lpc_ich.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/lpc_ich.c +2 -2
@@ -934,7 +934,7 @@ gpe0_done:lpc_ich_enable_gpio_space (dev);lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_GPIO ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); gpio_done:
@@ -1008,7 +1008,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) }lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_WDT ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); wdt_done:
Signature · 1 line
2.1.4
Ping on this.
Quoted 40 lines · Mika Westerberg
Using -1 as platform device id means that the platform driver core will not assign any id to the device (the device name will not have id at all). This results problems on systems that have multiple PCHs (Platform Controller HUBs) because all of them also include their own copy of LPC device.
All the subsequent device creations will fail because there already exists platform device with the same name.
Fix this by passing -2 as a platform device id. This makes the platform device core to allocate new ids automatically.
Signed-off-by Mika Westerberg <[email protected]>--- drivers/mfd/lpc_ich.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mfd/lpc_ich.c +2
-2@@ -934,7 +934,7 @@ gpe0_done:lpc_ich_enable_gpio_space (dev);lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_GPIO ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); gpio_done:@@ -1008,7 +1008,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) }lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_WDT ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); wdt_done:Signature · 1 line
2.1.4
Quoted 10 lines · Mika Westerberg
Using -1 as platform device id means that the platform driver core will not assign any id to the device (the device name will not have id at all). This results problems on systems that have multiple PCHs (Platform Controller HUBs) because all of them also include their own copy of LPC device.
All the subsequent device creations will fail because there already exists platform device with the same name.
Fix this by passing -2 as a platform device id. This makes the platform device core to allocate new ids automatically.
Please use the defines provided in:
include/linux/platform_device.h
Quoted 27 lines
Signed-off-by Mika Westerberg <[email protected]>--- drivers/mfd/lpc_ich.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mfd/lpc_ich.c +2
-2@@ -934,7 +934,7 @@ gpe0_done:lpc_ich_enable_gpio_space (dev);lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_GPIO ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); gpio_done:@@ -1008,7 +1008,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) }lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); - ret =mfd_add_devices (&dev->dev,-1 , &lpc_ich_cells[LPC_WDT ], + ret =mfd_add_devices (&dev->dev,-2 , &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); wdt_done:
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog