Skip to contentSkip to conversation

Patch "ipv4: Missing sk_nulls_node_init() in ping_unhash()." has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message May 8, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ipv4: Missing sk_nulls_node_init() in ping_unhash().

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipv4-missing-sk_nulls_node_init-in-ping_unhash.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri May 8 13:16:04 CEST 2015

From: "David S. Miller" <[email protected]>
Date: Fri, 1 May 2015 22:02:47 -0400
Subject: ipv4: Missing sk_nulls_node_init() in ping_unhash().

From: "David S. Miller" <[email protected]>

[ Upstream commit a134f083e79fb4c3d0a925691e732c56911b4326 ]

If we don't do that, then the poison value is left in the ->pprev backlink.

This can cause crashes if we do a disconnect, followed by a connect().

---
 net/ipv4/ping.c |    1 +
 1 file changed, 1 insertion(+)
net/ipv4/ping.c +1 -0
@@ -158,6 +158,7 @@ void ping_unhash(struct sock *sk)
 	if (sk_hashed(sk)) {
 		write_lock_bh(&ping_table.lock);
 		hlist_nulls_del(&sk->sk_nulls_node);
+		sk_nulls_node_init(&sk->sk_nulls_node);
 		sock_put(sk);
 		isk->inet_num = 0;
 		isk->inet_sport = 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/ipv4-missing-sk_nulls_node_init-in-ping_unhash.patch queue-4.0/bpf-fix-64-bit-divide.patch queue-4.0/cxgb4-fix-mc1-memory-offset-calculation.patch queue-4.0/mlx4-fix-tx-ring-affinity_mask-creation.patch queue-4.0/net-mlx4_en-schedule-napi-when-rx-buffers-allocation-fails.patch queue-4.0/route-use-ipv4_mtu-instead-of-raw-rt_pmtu.patch