 drivers/infiniband/hw/cxgb4/device.c | 4 ++--
 drivers/infiniband/hw/mlx4/main.c    | 3 +--
 drivers/infiniband/hw/mlx5/qp.c      | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

drivers/infiniband/hw/cxgb4/device.c +2 -2

index cf54d69..7e895d7 100644
@@ -1386,7 +1386,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
 					  t4_sq_host_wq_pidx(&qp->wq),
 					  t4_sq_wq_size(&qp->wq));
 		if (ret) {
-			pr_err(KERN_ERR MOD "%s: Fatal error - "
+			pr_err(MOD "%s: Fatal error - "
 			       "DB overflow recovery failed - "
 			       "error syncing SQ qid %u\n",
 			       pci_name(ctx->lldi.pdev), qp->wq.sq.qid);

@@ -1402,7 +1402,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
 					  t4_rq_wq_size(&qp->wq));
 
 		if (ret) {
-			pr_err(KERN_ERR MOD "%s: Fatal error - "
+			pr_err(MOD "%s: Fatal error - "
 			       "DB overflow recovery failed - "
 			       "error syncing RQ qid %u\n",
 			       pci_name(ctx->lldi.pdev), qp->wq.rq.qid);

drivers/infiniband/hw/mlx4/main.c +1 -2

index 57070c5..cc64400 100644
@@ -1569,8 +1569,7 @@ static void reset_gids_task(struct work_struct *work)
 			       MLX4_CMD_TIME_CLASS_B,
 			       MLX4_CMD_WRAPPED);
 		if (err)
-			pr_warn(KERN_WARNING
-				"set port %d command failed\n", gw->port);
+			pr_warn("set port %d command failed\n", gw->port);
 	}
 
 	mlx4_free_cmd_mailbox(dev, mailbox);

drivers/infiniband/hw/mlx5/qp.c +1 -1

index 4d7024b..d35f62d 100644
@@ -1392,7 +1392,7 @@ static int mlx5_set_path(struct mlx5_ib_dev *dev, const struct ib_ah_attr *ah,
 
 	if (ah->ah_flags & IB_AH_GRH) {
 		if (ah->grh.sgid_index >= gen->port[port - 1].gid_table_len) {
-			pr_err(KERN_ERR "sgid_index (%u) too large. max is %d\n",
+			pr_err("sgid_index (%u) too large. max is %d\n",
 			       ah->grh.sgid_index, gen->port[port - 1].gid_table_len);
 			return -EINVAL;
 		}

Doug Ledford

Applied

2015-05-12 19:53 UTC #1 lore raw

Quoted 9 lines · Joe Perches

These KERN_<LEVEL> uses are unnecessary with pr_<level> and cause bad logging output so remove them.
Signed-off-by Joe Perches <[email protected]>
Acked-by Steve Wise <[email protected]>
---
Originally sent Jan 5, This is refreshed against -next.

Quoted 7 lines

Now sent to the new maintainer too.
Rasmus Villemoes sent a similar patchset a month later.
https://lkml.org/lkml/2015/2/5/724
Rasmus' had an additional change that's useful.
I don't care which is applied.

Applied, thanks.

Signature · 2 lines

Doug Ledford <[email protected]>
              GPG KeyID: 0E572FDD